]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
net: tcp: Increase TCP_MIB_OUTRSTS even though fail to alloc skb
authorGao Feng <fgao@ikuai8.com>
Thu, 6 Apr 2017 15:05:49 +0000 (23:05 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sat, 8 Apr 2017 15:30:09 +0000 (08:30 -0700)
Because TCP_MIB_OUTRSTS is an important count, so always increase it
whatever send it successfully or not.

Now move the increment of TCP_MIB_OUTRSTS to the top of
tcp_send_active_reset to make sure it is increased always even though
fail to alloc skb.

Signed-off-by: Gao Feng <fgao@ikuai8.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp_output.c

index 22548b5f05cbe5a655e0c53df2d31c5cc2e8a702..c3c082ed38796f65948e7a1042e37813b71d5abf 100644 (file)
@@ -2999,6 +2999,8 @@ void tcp_send_active_reset(struct sock *sk, gfp_t priority)
 {
        struct sk_buff *skb;
 
+       TCP_INC_STATS(sock_net(sk), TCP_MIB_OUTRSTS);
+
        /* NOTE: No TCP options attached and we never retransmit this. */
        skb = alloc_skb(MAX_TCP_HEADER, priority);
        if (!skb) {
@@ -3014,8 +3016,6 @@ void tcp_send_active_reset(struct sock *sk, gfp_t priority)
        /* Send it off. */
        if (tcp_transmit_skb(sk, skb, 0, priority))
                NET_INC_STATS(sock_net(sk), LINUX_MIB_TCPABORTFAILED);
-
-       TCP_INC_STATS(sock_net(sk), TCP_MIB_OUTRSTS);
 }
 
 /* Send a crossed SYN-ACK during socket establishment.