]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
specialix.c: fix possible double-unlock
authorHarvey Harrison <harvey.harrison@gmail.com>
Tue, 4 Mar 2008 22:28:26 +0000 (14:28 -0800)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Wed, 5 Mar 2008 00:35:10 +0000 (16:35 -0800)
Noticed by sparse, trivial to see:
drivers/char/specialix.c:2112:3: warning: context imbalance in 'sx_throttle' - unexpected unlock

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/char/specialix.c

index c0e08c7bca2f4ef713c966eeed532164d33282e6..5ff83df67b447d18054bf45359c183d18fdb9e5a 100644 (file)
@@ -2109,7 +2109,6 @@ static void sx_throttle(struct tty_struct * tty)
        sx_out(bp, CD186x_CAR, port_No(port));
        spin_unlock_irqrestore(&bp->lock, flags);
        if (I_IXOFF(tty)) {
-               spin_unlock_irqrestore(&bp->lock, flags);
                sx_wait_CCR(bp);
                spin_lock_irqsave(&bp->lock, flags);
                sx_out(bp, CD186x_CCR, CCR_SSCH2);