]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
watchdog: simplify platform_get_resource_byname/devm_ioremap_resource
authorJulia Lawall <Julia.Lawall@lip6.fr>
Mon, 19 Aug 2013 08:51:52 +0000 (10:51 +0200)
committerWim Van Sebroeck <wim@iguana.be>
Tue, 10 Sep 2013 19:20:44 +0000 (21:20 +0200)
Remove unneeded error handling on the result of a call to
platform_get_resource_byname when the value is passed to devm_ioremap_resource.

A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression pdev,res,e,e1;
expression ret != 0;
identifier l;
@@

  res = platform_get_resource_byname(...);
- if (res == NULL) { ... \(goto l;\|return ret;\) }
  e = devm_ioremap_resource(e1, res);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
drivers/watchdog/ar7_wdt.c

index 2f3cc8fb471af041ffc82039b98c461f52d38c3b..b3709f9cf5beab1d5e6d8f51136ae90e3bf23726 100644 (file)
@@ -280,11 +280,6 @@ static int ar7_wdt_probe(struct platform_device *pdev)
 
        ar7_regs_wdt =
                platform_get_resource_byname(pdev, IORESOURCE_MEM, "regs");
-       if (!ar7_regs_wdt) {
-               pr_err("could not get registers resource\n");
-               return -ENODEV;
-       }
-
        ar7_wdt = devm_ioremap_resource(&pdev->dev, ar7_regs_wdt);
        if (IS_ERR(ar7_wdt))
                return PTR_ERR(ar7_wdt);