]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
drivers/parisc/pdc_stable.c: use WARN
authorJulia Lawall <Julia.Lawall@lip6.fr>
Sat, 3 Nov 2012 10:58:36 +0000 (10:58 +0000)
committerHelge Deller <deller@gmx.de>
Wed, 20 Feb 2013 21:49:07 +0000 (22:49 +0100)
Use WARN rather than printk followed by WARN_ON(1), for conciseness.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Helge Deller <deller@gmx.de>
drivers/parisc/pdc_stable.c

index 246a92f677e4c8b7fc4febe1560b7aa3bdbfb60c..0f54ab6260dfdcd719542e2a420db5b568b15ba4 100644 (file)
@@ -212,12 +212,10 @@ pdcspath_store(struct pdcspath_entry *entry)
                        entry, devpath, entry->addr);
 
        /* addr, devpath and count must be word aligned */
-       if (pdc_stable_write(entry->addr, devpath, sizeof(*devpath)) != PDC_OK) {
-               printk(KERN_ERR "%s: an error occurred when writing to PDC.\n"
+       if (pdc_stable_write(entry->addr, devpath, sizeof(*devpath)) != PDC_OK)
+               WARN(1, KERN_ERR "%s: an error occurred when writing to PDC.\n"
                                "It is likely that the Stable Storage data has been corrupted.\n"
                                "Please check it carefully upon next reboot.\n", __func__);
-               WARN_ON(1);
-       }
                
        /* kobject is already registered */
        entry->ready = 2;