]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
spi: s3c64xx: fix reference leak to master in s3c64xx_spi_remove()
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Tue, 12 Jul 2016 11:08:42 +0000 (11:08 +0000)
committerMark Brown <broonie@kernel.org>
Thu, 14 Jul 2016 16:21:52 +0000 (17:21 +0100)
Once a spi_master_get() call succeeds, we need an additional
spi_master_put() call to free the memory, otherwise we will
leak a reference to master. Fix by removing the unnecessary
spi_master_get() call.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Reviewed-by: Andi Shyti <andi.shyti@samsung.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-s3c64xx.c

index df88fa161d8aad8b6a69e5e01cc301cc3c5384b9..001c9ebf884dd6c9f48b35b4e0456baf28471372 100644 (file)
@@ -1211,7 +1211,7 @@ err0:
 
 static int s3c64xx_spi_remove(struct platform_device *pdev)
 {
-       struct spi_master *master = spi_master_get(platform_get_drvdata(pdev));
+       struct spi_master *master = platform_get_drvdata(pdev);
        struct s3c64xx_spi_driver_data *sdd = spi_master_get_devdata(master);
 
        pm_runtime_get_sync(&pdev->dev);