]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
netfilter: nft_reject: fix endianness in dump function
authorEric Leblond <eric@regit.org>
Thu, 12 Dec 2013 07:51:59 +0000 (08:51 +0100)
committerPablo Neira Ayuso <pablo@netfilter.org>
Thu, 12 Dec 2013 08:37:39 +0000 (09:37 +0100)
The dump function in nft_reject_ipv4 was not converting a u32
field to network order before sending it to userspace, this
needs to happen for consistency with other nf_tables and
nfnetlink subsystems.

Signed-off-by: Eric Leblond <eric@regit.org>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/ipv4/netfilter/nft_reject_ipv4.c

index fff5ba1a33b76321f70d1365d072f7330d524ea9..4a5e94ac314a8cfdae20d8e393724ea2d01bd588 100644 (file)
@@ -72,7 +72,7 @@ static int nft_reject_dump(struct sk_buff *skb, const struct nft_expr *expr)
 {
        const struct nft_reject *priv = nft_expr_priv(expr);
 
-       if (nla_put_be32(skb, NFTA_REJECT_TYPE, priv->type))
+       if (nla_put_be32(skb, NFTA_REJECT_TYPE, htonl(priv->type)))
                goto nla_put_failure;
 
        switch (priv->type) {