SCSI: enclosure: fix error path - actually return ERR_PTR() on error

commit a91c1be21704113b023919826c6d531da46656ef upstream.

we also need to clean up and free the cdev.

Reported-by: Jani Nikula <ext-jani.1.nikula@nokia.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

diff --git a/drivers/misc/enclosure.c b/drivers/misc/enclosure.c
index 0736cff9d97a2c7499b4c91eaf30beac046ad9b6..f57abe84dde7f64d3060093649420c8c1f7737bc 100644 (file)
--- a/drivers/misc/enclosure.c
+++ b/drivers/misc/enclosure.c
@@ -264,8 +264,11 @@ enclosure_component_register(struct enclosure_device *edev,
        cdev->groups = enclosure_groups;
 
        err = device_register(cdev);
-       if (err)
-               ERR_PTR(err);
+       if (err) {
+               ecomp->number = -1;
+               put_device(cdev);
+               return ERR_PTR(err);
+       }
 
        return ecomp;
 }