]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
NVMe: Requeue requests on suspended queues
authorKeith Busch <keith.busch@intel.com>
Thu, 11 Feb 2016 20:05:42 +0000 (13:05 -0700)
committerJens Axboe <axboe@fb.com>
Fri, 12 Feb 2016 15:10:08 +0000 (08:10 -0700)
It's possible a request may get to the driver after the nvme queue was
disabled. This has the request requeue if that happens.

Note the request is still "started" by the driver, but requeuing will
clear the start state for timeout handling.

Signed-off-by: Keith Busch <keith.busch@intel.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Reviewed-by: Sagi Grimberg <sagig@mellanox.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
drivers/nvme/host/pci.c

index 72ef8322d32ac7180912e2ae2cf38245f3713d9a..e5c2bea01dbf55365aad109e0dd80c1f699dddfe 100644 (file)
@@ -678,6 +678,11 @@ static int nvme_queue_rq(struct blk_mq_hw_ctx *hctx,
        blk_mq_start_request(req);
 
        spin_lock_irq(&nvmeq->q_lock);
+       if (unlikely(nvmeq->cq_vector < 0)) {
+               ret = BLK_MQ_RQ_QUEUE_BUSY;
+               spin_unlock_irq(&nvmeq->q_lock);
+               goto out;
+       }
        __nvme_submit_cmd(nvmeq, &cmnd);
        nvme_process_cq(nvmeq);
        spin_unlock_irq(&nvmeq->q_lock);