]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
mwifiex: Call pci_release_region after calling pci_disable_device
authorYogesh Ashok Powar <yogeshp@marvell.com>
Tue, 23 Apr 2013 23:49:48 +0000 (16:49 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 8 May 2013 02:51:52 +0000 (19:51 -0700)
commit 5b0d9b218b74042ff72bf4bfda6eeb2e4bf98397 upstream.

"drivers should call pci_release_region() AFTER
calling pci_disable_device()"

Please refer section 3.2 Request MMIO/IOP resources
in Documentation/PCI/pci.txt

Signed-off-by: Avinash Patil <patila@marvell.com>
Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
Signed-off-by: Yogesh Ashok Powar <yogeshp@marvell.com>
Signed-off-by: Bing Zhao <bzhao@marvell.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/wireless/mwifiex/pcie.c

index 8ffc6b7721d03de8d2e97d3e42d5cde12447a4b5..59e946ac46474e2113c4b0c21b941c97e1504022 100644 (file)
@@ -1828,9 +1828,9 @@ static void mwifiex_pcie_cleanup(struct mwifiex_adapter *adapter)
        if (pdev) {
                pci_iounmap(pdev, card->pci_mmap);
                pci_iounmap(pdev, card->pci_mmap1);
+               pci_disable_device(pdev);
                pci_release_region(pdev, 2);
                pci_release_region(pdev, 0);
-               pci_disable_device(pdev);
                pci_set_drvdata(pdev, NULL);
        }
 }