]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
scsi: qla2xxx: Remove unused irq_cmd_count field.
authorQuinn Tran <quinn.tran@cavium.com>
Fri, 2 Jun 2017 16:12:06 +0000 (09:12 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 13 Jun 2017 00:48:08 +0000 (20:48 -0400)
When driver is unloaded, all sessions are torn down, all commmands are
flushed, chip is reset to ensure there is no knowledge of target mode in
ISP. The irq_cmd_count field was used to make sure all commands are
processed on top of that.  The irq_cmd_count is now redundant and not
needed.

Signed-off-by: Quinn Tran <quinn.tran@cavium.com>
Signed-off-by: Himanshu Madhani <himanshu.madhani@cavium.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_target.c
drivers/scsi/qla2xxx/qla_target.h

index f9ccf845d084a9c8407bc940bf9c70831cd6dc0e..a8e57072019be2002a17de90ed3a736a7d83fe8a 100644 (file)
@@ -5355,8 +5355,6 @@ static void qlt_response_pkt(struct scsi_qla_host *vha, response_t *pkt)
         * Otherwise, some commands can stuck.
         */
 
-       tgt->irq_cmd_count++;
-
        switch (pkt->entry_type) {
        case CTIO_CRC2:
        case CTIO_TYPE7:
@@ -5382,10 +5380,8 @@ static void qlt_response_pkt(struct scsi_qla_host *vha, response_t *pkt)
                }
 
                rc = qlt_chk_qfull_thresh_hold(vha, atio, true);
-               if (rc != 0) {
-                       tgt->irq_cmd_count--;
+               if (rc != 0)
                        return;
-               }
 
                rc = qlt_handle_cmd_for_atio(vha, atio);
                if (unlikely(rc != 0)) {
@@ -5517,7 +5513,6 @@ static void qlt_response_pkt(struct scsi_qla_host *vha, response_t *pkt)
                break;
        }
 
-       tgt->irq_cmd_count--;
 }
 
 /*
@@ -5547,7 +5542,6 @@ void qlt_async_event(uint16_t code, struct scsi_qla_host *vha,
         * Otherwise, some commands can stuck.
         */
 
-       tgt->irq_cmd_count++;
 
        switch (code) {
        case MBA_RESET:                 /* Reset */
@@ -5635,7 +5629,6 @@ void qlt_async_event(uint16_t code, struct scsi_qla_host *vha,
                break;
        }
 
-       tgt->irq_cmd_count--;
 }
 
 static fc_port_t *qlt_get_port_database(struct scsi_qla_host *vha,
index 07ff565485b7682f28999e578a580107a61d5fb2..c328a267c4c39b508ade46893b15934cc6874f98 100644 (file)
@@ -790,7 +790,6 @@ struct qla_tgt {
         * because req_pkt() can drop/reaquire HW lock inside. Protected by
         * HW lock.
         */
-       int irq_cmd_count;
        int atio_irq_cmd_count;
 
        int datasegs_per_cmd, datasegs_per_cont, sg_tablesize;