]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
dvb-core: Release semaphore on error path dvb_register_device()
authorSantosh Nayak <santoshprasadnayak@gmail.com>
Sat, 23 Jun 2012 10:59:54 +0000 (07:59 -0300)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 25 Jul 2012 03:11:11 +0000 (04:11 +0100)
commit 82163edcdfa4eb3d74516cc8e9f38dd3d039b67d upstream.

There is a missing "up_write()" here. Semaphore should be released
before returning error value.

Signed-off-by: Santosh Nayak <santoshprasadnayak@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/media/dvb/dvb-core/dvbdev.c

index f73287775953599c80062c978d73604b82dc07e0..d5cda35dcc7e09b3dd7434e7c63cfeadb9302d1b 100644 (file)
@@ -243,6 +243,7 @@ int dvb_register_device(struct dvb_adapter *adap, struct dvb_device **pdvbdev,
        if (minor == MAX_DVB_MINORS) {
                kfree(dvbdevfops);
                kfree(dvbdev);
+               up_write(&minor_rwsem);
                mutex_unlock(&dvbdev_register_lock);
                return -EINVAL;
        }