]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
liquidio CN23XX: bitwise vs logical AND typo
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 18 Nov 2016 11:47:35 +0000 (14:47 +0300)
committerDavid S. Miller <davem@davemloft.net>
Fri, 18 Nov 2016 19:03:32 +0000 (14:03 -0500)
We obviously intended a bitwise AND here, not a logical one.

Fixes: 8c978d059224 ("liquidio CN23XX: Mailbox support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/cavium/liquidio/octeon_mailbox.c

index 5309384e4cd09e430f7462325e21a9840cb033a9..73696b427f068372a747d0689b3828799c2c36d2 100644 (file)
@@ -301,7 +301,7 @@ int octeon_mbox_process_message(struct octeon_mbox *mbox)
                       sizeof(struct octeon_mbox_cmd));
                if (!mbox_cmd.msg.s.resp_needed) {
                        mbox->state &= ~OCTEON_MBOX_STATE_REQUEST_RECEIVED;
-                       if (!(mbox->state &&
+                       if (!(mbox->state &
                              OCTEON_MBOX_STATE_RESPONSE_PENDING))
                                mbox->state = OCTEON_MBOX_STATE_IDLE;
                        writeq(OCTEON_PFVFSIG, mbox->mbox_read_reg);