]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
sparc64: Fix bug in ("sparc64: Flush TLB before releasing pages.")
authorDavid Miller <davem@davemloft.net>
Wed, 8 Apr 2009 09:51:47 +0000 (02:51 -0700)
committerChris Wright <chrisw@sous-sol.org>
Mon, 27 Apr 2009 17:36:58 +0000 (10:36 -0700)
[ No upstream commit, this regression was added only to 2.6.29.1 ]

Unfortunately I merged an earlier version of commit
b6816b706138c3870f03115071872cad824f90b4 ("sparc64: Flush TLB before
releasing pages.") than what I actually tested and merged upstream.

Simply diffing asm/tlb_64.h in Linus's tree vs. what ended up in
2.6.29.1 confirms this.

Sync things up to fix BUG() triggers some users are seeing.

Reported-by: Dennis Gilmore <dennis@ausil.us>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
arch/sparc/include/asm/tlb_64.h

index 0aaa086fde111aa0940dd1081707d4ee95e2ba56..ee38e731bfa635587afd73bac991fa69fad8ebec 100644 (file)
@@ -57,9 +57,9 @@ static inline struct mmu_gather *tlb_gather_mmu(struct mm_struct *mm, unsigned i
 
 static inline void tlb_flush_mmu(struct mmu_gather *mp)
 {
+       if (!mp->fullmm)
+               flush_tlb_pending();
        if (mp->need_flush) {
-               if (!mp->fullmm)
-                       flush_tlb_pending();
                free_pages_and_swap_cache(mp->pages, mp->pages_nr);
                mp->pages_nr = 0;
                mp->need_flush = 0;