]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
cx25840: fix probing of cx2583x chips
authorSven Barth <pascaldragon@googlemail.com>
Mon, 14 Feb 2011 01:09:43 +0000 (22:09 -0300)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 14 Mar 2011 21:17:41 +0000 (14:17 -0700)
commit 1e6406b8f0dc1ae7d7c39c9e1ac6ca78e016ebfb upstream.

Fix the probing of cx2583x chips, because two controls were clustered
that are not created for these chips.

This regression was introduced in 2.6.36.

Signed-off-by: Sven Barth <pascaldragon@googlemail.com>
Signed-off-by: Andy Walls <awalls@md.metrocast.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/media/video/cx25840/cx25840-core.c

index f16461844c5c0063e281da22b8cd3e27fe6d28f4..a201d9c57c834a3b08722c9c9f9f05aa0392af6e 100644 (file)
@@ -2031,7 +2031,8 @@ static int cx25840_probe(struct i2c_client *client,
                kfree(state);
                return err;
        }
-       v4l2_ctrl_cluster(2, &state->volume);
+       if (!is_cx2583x(state))
+               v4l2_ctrl_cluster(2, &state->volume);
        v4l2_ctrl_handler_setup(&state->hdl);
 
        cx25840_ir_probe(sd);