]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
kcm: fix a signedness in kcm_splice_read()
authorWANG Cong <xiyou.wangcong@gmail.com>
Tue, 17 May 2016 21:05:49 +0000 (14:05 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 19 May 2016 18:26:51 +0000 (11:26 -0700)
skb_splice_bits() returns int, kcm_splice_read() returns ssize_t,
both are signed.

We may need another patch to make them all ssize_t, but that
deserves a separated patch.

Fixes: 91687355b927 ("kcm: Splice support")
Reported-by: David Binderman <linuxdev.baldrick@gmail.com>
Cc: Tom Herbert <tom@herbertland.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/kcm/kcmsock.c

index 40662d73204f73356a76a108b6e82ce6e5454c86..0b68ba730a067ad4d9be9d75f42034d709a762aa 100644 (file)
@@ -1483,7 +1483,7 @@ static ssize_t kcm_splice_read(struct socket *sock, loff_t *ppos,
        long timeo;
        struct kcm_rx_msg *rxm;
        int err = 0;
-       size_t copied;
+       ssize_t copied;
        struct sk_buff *skb;
 
        /* Only support splice for SOCKSEQPACKET */