]> git.kernelconcepts.de Git - karo-tx-uboot.git/commit
pxe: Ensure we don't overflow bootargs
authorIan Campbell <ian.campbell@citrix.com>
Fri, 3 Oct 2014 13:29:01 +0000 (14:29 +0100)
committerTom Rini <trini@ti.com>
Fri, 10 Oct 2014 13:44:21 +0000 (09:44 -0400)
commit64a0c24726530696bf0c2cdaa75d171d957a7ee0
treec4d2f6e83d2452c6536760a1ee95b326b795147d
parentf885b849681ce0f15c2df313f38ae06a601be506
pxe: Ensure we don't overflow bootargs

On a couple of platforms I've tripped over long PXE append lines overflowing
this array, due to having CONFIG_SYS_CBSIZE == 256. When doing preseeded Debian
installs it's pretty trivial to exceed that.

Since the symptom can be a silent hang or a crash add a check. Of course the
affected boards would also need an increased CBSIZE to actually work.

Note that due to the printing of the final bootargs string CONFIG_SYS_PBSIZE
also needs to be sufficiently large.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
[trini: Use %zd not %d in printf for all args]
Signed-off-by: Tom Rini <trini@ti.com>
common/cmd_pxe.c