]> git.kernelconcepts.de Git - karo-tx-uboot.git/commit
env_nand: fix incorrect size parameter to ALLOC_CACHE_ALIGN_BUFFER
authorStephen Warren <swarren@nvidia.com>
Fri, 7 Sep 2012 09:15:33 +0000 (09:15 +0000)
committerTom Rini <trini@ti.com>
Tue, 18 Sep 2012 19:01:51 +0000 (12:01 -0700)
commit78b2de802f5f996d1e6d9383d1e05194351c429b
treef425b0cbb63769796c514279247bd2d8c0cb6a22
parent535c74f80cb9eff0fa66ce750fc7fc8a8539635c
env_nand: fix incorrect size parameter to ALLOC_CACHE_ALIGN_BUFFER

The third parameter to ALLOC_CACHE_ALIGN_BUFFER is not size (as named),
but rather count (number of elements of the type to allocate). The
current code ends up allocating one copy of env_t for each byte in its
size, which quite possibly ends up overflowing RAM.

This fixes a bug in commit 3801a15 "env_nand: align NAND buffers".

Reported-by: Prabhakar Lad <prabhakar.csengg@gmail.com>
Signed-off-by: Stephen Warren <swarren@nvidia.com>
Reported-by: Prabhakar Lad <prabhakar.lad@ti.com>
common/env_nand.c