]> git.kernelconcepts.de Git - karo-tx-uboot.git/commit
net: Revert "tftp: adjust settings to be suitable for 100Mbit ethernet"
authorBin Meng <bmeng.cn@gmail.com>
Fri, 28 Aug 2015 05:25:51 +0000 (22:25 -0700)
committerSimon Glass <sjg@chromium.org>
Wed, 9 Sep 2015 13:48:03 +0000 (07:48 -0600)
commitaf2ca59e6352ba86b9cf8d8a5b96f7df6cecb044
tree2ab9a30685d6d778f1b757faae488e97bfee50f8
parent548fb8777d06438c0a6c2177530c387b5986cb68
net: Revert "tftp: adjust settings to be suitable for 100Mbit ethernet"

Commit 620776d "tftp: adjust settings to be suitable for 100Mbit ethernet"
causes the following error message when trying to load a file using 'tftp'
command via a tftp server.

    TFTP error: 'Unsupported option(s) requested' (8)

This is due to with commit 620776d changes, the tftp option 'timeout'
value is now set to zero which is an invalid value as per RFC2349 [1].
Valid values range between "1" and "255" seconds, inclusive. With some
tftp servers that strictly implement the RFC requirement, it reports
such an error message.

Revert commit 620776d for RFC compliance.

[1] https://www.ietf.org/rfc/rfc2349.txt

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
net/tftp.c