]> git.kernelconcepts.de Git - karo-tx-uboot.git/blobdiff - drivers/net/tsec.c
tsec: add micrel ksz804 phy
[karo-tx-uboot.git] / drivers / net / tsec.c
index 76902bcd83505d2262d7f45737375d26156f2b1f..bc2707f17a7d15a2c4d5277660a72f3c1dc08be9 100644 (file)
@@ -48,14 +48,15 @@ static int tsec_send(struct eth_device *dev,
                     volatile void *packet, int length);
 static int tsec_recv(struct eth_device *dev);
 static int tsec_init(struct eth_device *dev, bd_t * bd);
+static int tsec_initialize(bd_t * bis, struct tsec_info_struct *tsec_info);
 static void tsec_halt(struct eth_device *dev);
 static void init_registers(volatile tsec_t * regs);
 static void startup_tsec(struct eth_device *dev);
 static int init_phy(struct eth_device *dev);
 void write_phy_reg(struct tsec_private *priv, uint regnum, uint value);
 uint read_phy_reg(struct tsec_private *priv, uint regnum);
-struct phy_info *get_phy_info(struct eth_device *dev);
-void phy_run_commands(struct tsec_private *priv, struct phy_cmd *cmd);
+static struct phy_info *get_phy_info(struct eth_device *dev);
+static void phy_run_commands(struct tsec_private *priv, struct phy_cmd *cmd);
 static void adjust_link(struct eth_device *dev);
 #if defined(CONFIG_MII) || defined(CONFIG_CMD_MII) \
        && !defined(BITBANGMII)
@@ -112,7 +113,7 @@ int tsec_standard_init(bd_t *bis)
 /* Initialize device structure. Returns success if PHY
  * initialization succeeded (i.e. if it recognizes the PHY)
  */
-int tsec_initialize(bd_t * bis, struct tsec_info_struct *tsec_info)
+static int tsec_initialize(bd_t * bis, struct tsec_info_struct *tsec_info)
 {
        struct eth_device *dev;
        int i;
@@ -174,7 +175,7 @@ int tsec_initialize(bd_t * bis, struct tsec_info_struct *tsec_info)
  * that it returns success if the link is up, failure otherwise.
  * This allows u-boot to find the first active controller.
  */
-int tsec_init(struct eth_device *dev, bd_t * bd)
+static int tsec_init(struct eth_device *dev, bd_t * bd)
 {
        uint tempval;
        char tmpbuf[MAC_ADDR_LEN];
@@ -235,7 +236,8 @@ static void tsec_local_mdio_write(volatile tsec_mdio_t *phyregs, uint addr,
 
 
 /* Provide the default behavior of writing the PHY of this ethernet device */
-#define write_phy_reg(priv, regnum, value) tsec_local_mdio_write(priv->phyregs,priv->phyaddr,regnum,value)
+#define write_phy_reg(priv, regnum, value) \
+       tsec_local_mdio_write(priv->phyregs,priv->phyaddr,regnum,value)
 
 /* Reads register regnum on the device's PHY through the
  * specified registers.         It lowers and raises the read
@@ -243,7 +245,8 @@ static void tsec_local_mdio_write(volatile tsec_mdio_t *phyregs, uint addr,
  * notvalid bit cleared), and the bus to cease activity (miimind
  * busy bit cleared), and then returns the value
  */
-uint tsec_local_mdio_read(volatile tsec_mdio_t *phyregs, uint phyid, uint regnum)
+static uint tsec_local_mdio_read(volatile tsec_mdio_t *phyregs,
+                               uint phyid, uint regnum)
 {
        uint value;
 
@@ -269,7 +272,8 @@ uint tsec_local_mdio_read(volatile tsec_mdio_t *phyregs, uint phyid, uint regnum
 }
 
 /* #define to provide old read_phy_reg functionality without duplicating code */
-#define read_phy_reg(priv,regnum) tsec_local_mdio_read(priv->phyregs,priv->phyaddr,regnum)
+#define read_phy_reg(priv,regnum) \
+       tsec_local_mdio_read(priv->phyregs,priv->phyaddr,regnum)
 
 #define TBIANA_SETTINGS ( \
                TBIANA_ASYMMETRIC_PAUSE \
@@ -277,18 +281,22 @@ uint tsec_local_mdio_read(volatile tsec_mdio_t *phyregs, uint phyid, uint regnum
                | TBIANA_FULL_DUPLEX \
                )
 
-/* Force the TBI PHY into 1000Mbps full duplex when in SGMII mode */
+/* By default force the TBI PHY into 1000Mbps full duplex when in SGMII mode */
+#ifndef CONFIG_TSEC_TBICR_SETTINGS
 #define TBICR_SETTINGS ( \
                TBICR_PHY_RESET \
                | TBICR_FULL_DUPLEX \
                | TBICR_SPEED1_SET \
                )
+#else
+#define TBICR_SETTINGS CONFIG_TSEC_TBICR_SETTINGS
+#endif /* CONFIG_TSEC_TBICR_SETTINGS */
 
 /* Configure the TBI for SGMII operation */
 static void tsec_configure_serdes(struct tsec_private *priv)
 {
-       /* Access TBI PHY registers at given TSEC register offset as opposed to the
-        * register offset used for external PHY accesses */
+       /* Access TBI PHY registers at given TSEC register offset as opposed
+        * to the register offset used for external PHY accesses */
        tsec_local_mdio_write(priv->phyregs_sgmii, priv->regs->tbipa, TBI_ANA,
                        TBIANA_SETTINGS);
        tsec_local_mdio_write(priv->phyregs_sgmii, priv->regs->tbipa, TBI_TBICON,
@@ -343,7 +351,7 @@ static int init_phy(struct eth_device *dev)
  * Returns which value to write to the control register.
  * For 10/100, the value is slightly different
  */
-uint mii_cr_init(uint mii_reg, struct tsec_private * priv)
+static uint mii_cr_init(uint mii_reg, struct tsec_private * priv)
 {
        if (priv->flags & TSEC_GIGABIT)
                return MIIM_CONTROL_INIT;
@@ -354,7 +362,7 @@ uint mii_cr_init(uint mii_reg, struct tsec_private * priv)
 /*
  * Wait for auto-negotiation to complete, then determine link
  */
-uint mii_parse_sr(uint mii_reg, struct tsec_private * priv)
+static uint mii_parse_sr(uint mii_reg, struct tsec_private * priv)
 {
        /*
         * Wait if the link is up, and autonegotiation is in progress
@@ -408,7 +416,7 @@ uint mii_parse_sr(uint mii_reg, struct tsec_private * priv)
  *
  * Stolen from Linux's mii.c and phy_device.c
  */
-uint mii_parse_link(uint mii_reg, struct tsec_private *priv)
+static uint mii_parse_link(uint mii_reg, struct tsec_private *priv)
 {
        /* We're using autonegotiation */
        if (mii_reg & PHY_BMSR_AUTN_ABLE) {
@@ -477,7 +485,7 @@ uint mii_parse_link(uint mii_reg, struct tsec_private *priv)
  * link.  "Ethernet@Wirespeed" reduces advertised speed until link
  * can be achieved.
  */
-uint mii_BCM54xx_wirespeed(uint mii_reg, struct tsec_private *priv)
+static uint mii_BCM54xx_wirespeed(uint mii_reg, struct tsec_private *priv)
 {
        return (read_phy_reg(priv, mii_reg) & 0x8FFF) | 0x8010;
 }
@@ -486,7 +494,7 @@ uint mii_BCM54xx_wirespeed(uint mii_reg, struct tsec_private *priv)
  * Parse the BCM54xx status register for speed and duplex information.
  * The linux sungem_phy has this information, but in a table format.
  */
-uint mii_parse_BCM54xx_sr(uint mii_reg, struct tsec_private *priv)
+static uint mii_parse_BCM54xx_sr(uint mii_reg, struct tsec_private *priv)
 {
        /* If there is no link, speed and duplex don't matter */
        if (!priv->link)
@@ -526,12 +534,110 @@ uint mii_parse_BCM54xx_sr(uint mii_reg, struct tsec_private *priv)
        }
 
        return 0;
+}
+
+/*
+ * Find out if PHY is in copper or serdes mode by looking at Expansion Reg
+ * 0x42 - "Operating Mode Status Register"
+ */
+static int BCM8482_is_serdes(struct tsec_private *priv)
+{
+       u16 val;
+       int serdes = 0;
+
+       write_phy_reg(priv, MIIM_BCM54XX_EXP_SEL, MIIM_BCM54XX_EXP_SEL_ER | 0x42);
+       val = read_phy_reg(priv, MIIM_BCM54XX_EXP_DATA);
+
+       switch (val & 0x1f) {
+       case 0x0d:      /* RGMII-to-100Base-FX */
+       case 0x0e:      /* RGMII-to-SGMII */
+       case 0x0f:      /* RGMII-to-SerDes */
+       case 0x12:      /* SGMII-to-SerDes */
+       case 0x13:      /* SGMII-to-100Base-FX */
+       case 0x16:      /* SerDes-to-Serdes */
+               serdes = 1;
+               break;
+       case 0x6:       /* RGMII-to-Copper */
+       case 0x14:      /* SGMII-to-Copper */
+       case 0x17:      /* SerDes-to-Copper */
+               break;
+       default:
+               printf("ERROR, invalid PHY mode (0x%x\n)", val);
+               break;
+       }
+
+       return serdes;
+}
+
+/*
+ * Determine SerDes link speed and duplex from Expansion reg 0x42 "Operating
+ * Mode Status Register"
+ */
+uint mii_parse_BCM5482_serdes_sr(struct tsec_private *priv)
+{
+       u16 val;
+       int i = 0;
+
+       /* Wait 1s for link - Clause 37 autonegotiation happens very fast */
+       while (1) {
+               write_phy_reg(priv, MIIM_BCM54XX_EXP_SEL,
+                               MIIM_BCM54XX_EXP_SEL_ER | 0x42);
+               val = read_phy_reg(priv, MIIM_BCM54XX_EXP_DATA);
+
+               if (val & 0x8000)
+                       break;
+
+               if (i++ > 1000) {
+                       priv->link = 0;
+                       return 1;
+               }
+
+               udelay(1000);   /* 1 ms */
+       }
+
+       priv->link = 1;
+       switch ((val >> 13) & 0x3) {
+       case (0x00):
+               priv->speed = 10;
+               break;
+       case (0x01):
+               priv->speed = 100;
+               break;
+       case (0x02):
+               priv->speed = 1000;
+               break;
+       }
+
+       priv->duplexity = (val & 0x1000) == 0x1000;
+
+       return 0;
+}
+
+/*
+ * Figure out if BCM5482 is in serdes or copper mode and determine link
+ * configuration accordingly
+ */
+static uint mii_parse_BCM5482_sr(uint mii_reg, struct tsec_private *priv)
+{
+       if (BCM8482_is_serdes(priv)) {
+               mii_parse_BCM5482_serdes_sr(priv);
+               priv->flags |= TSEC_FIBER;
+       } else {
+               /* Wait for auto-negotiation to complete or fail */
+               mii_parse_sr(mii_reg, priv);
+
+               /* Parse BCM54xx copper aux status register */
+               mii_reg = read_phy_reg(priv, MIIM_BCM54xx_AUXSTATUS);
+               mii_parse_BCM54xx_sr(mii_reg, priv);
+       }
 
+       return 0;
 }
+
 /* Parse the 88E1011's status register for speed and duplex
  * information
  */
-uint mii_parse_88E1011_psr(uint mii_reg, struct tsec_private * priv)
+static uint mii_parse_88E1011_psr(uint mii_reg, struct tsec_private * priv)
 {
        uint speed;
 
@@ -589,7 +695,7 @@ uint mii_parse_88E1011_psr(uint mii_reg, struct tsec_private * priv)
 /* Parse the RTL8211B's status register for speed and duplex
  * information
  */
-uint mii_parse_RTL8211B_sr(uint mii_reg, struct tsec_private * priv)
+static uint mii_parse_RTL8211B_sr(uint mii_reg, struct tsec_private * priv)
 {
        uint speed;
 
@@ -647,7 +753,7 @@ uint mii_parse_RTL8211B_sr(uint mii_reg, struct tsec_private * priv)
 /* Parse the cis8201's status register for speed and duplex
  * information
  */
-uint mii_parse_cis8201(uint mii_reg, struct tsec_private * priv)
+static uint mii_parse_cis8201(uint mii_reg, struct tsec_private * priv)
 {
        uint speed;
 
@@ -675,7 +781,7 @@ uint mii_parse_cis8201(uint mii_reg, struct tsec_private * priv)
 /* Parse the vsc8244's status register for speed and duplex
  * information
  */
-uint mii_parse_vsc8244(uint mii_reg, struct tsec_private * priv)
+static uint mii_parse_vsc8244(uint mii_reg, struct tsec_private * priv)
 {
        uint speed;
 
@@ -703,7 +809,7 @@ uint mii_parse_vsc8244(uint mii_reg, struct tsec_private * priv)
 /* Parse the DM9161's status register for speed and duplex
  * information
  */
-uint mii_parse_dm9161_scsr(uint mii_reg, struct tsec_private * priv)
+static uint mii_parse_dm9161_scsr(uint mii_reg, struct tsec_private * priv)
 {
        if (mii_reg & (MIIM_DM9161_SCSR_100F | MIIM_DM9161_SCSR_100H))
                priv->speed = 100;
@@ -721,7 +827,7 @@ uint mii_parse_dm9161_scsr(uint mii_reg, struct tsec_private * priv)
 /*
  * Hack to write all 4 PHYs with the LED values
  */
-uint mii_cis8204_fixled(uint mii_reg, struct tsec_private * priv)
+static uint mii_cis8204_fixled(uint mii_reg, struct tsec_private * priv)
 {
        uint phyid;
        volatile tsec_mdio_t *regbase = priv->phyregs;
@@ -739,7 +845,7 @@ uint mii_cis8204_fixled(uint mii_reg, struct tsec_private * priv)
        return MIIM_CIS8204_SLEDCON_INIT;
 }
 
-uint mii_cis8204_setmode(uint mii_reg, struct tsec_private * priv)
+static uint mii_cis8204_setmode(uint mii_reg, struct tsec_private * priv)
 {
        if (priv->flags & TSEC_REDUCED)
                return MIIM_CIS8204_EPHYCON_INIT | MIIM_CIS8204_EPHYCON_RGMII;
@@ -747,7 +853,7 @@ uint mii_cis8204_setmode(uint mii_reg, struct tsec_private * priv)
                return MIIM_CIS8204_EPHYCON_INIT;
 }
 
-uint mii_m88e1111s_setmode(uint mii_reg, struct tsec_private *priv)
+static uint mii_m88e1111s_setmode(uint mii_reg, struct tsec_private *priv)
 {
        uint mii_data = read_phy_reg(priv, mii_reg);
 
@@ -839,8 +945,9 @@ static void adjust_link(struct eth_device *dev)
                        break;
                }
 
-               printf("Speed: %d, %s duplex\n", priv->speed,
-                      (priv->duplexity) ? "full" : "half");
+               printf("Speed: %d, %s duplex%s\n", priv->speed,
+                      (priv->duplexity) ? "full" : "half",
+                      (priv->flags & TSEC_FIBER) ? ", fiber mode" : "");
 
        } else {
                printf("%s: No link.\n", dev->name);
@@ -979,7 +1086,8 @@ static void tsec_halt(struct eth_device *dev)
        regs->dmactrl &= ~(DMACTRL_GRS | DMACTRL_GTS);
        regs->dmactrl |= (DMACTRL_GRS | DMACTRL_GTS);
 
-       while (!(regs->ievent & (IEVENT_GRSC | IEVENT_GTSC))) ;
+       while ((regs->ievent & (IEVENT_GRSC | IEVENT_GTSC))
+               != (IEVENT_GRSC | IEVENT_GTSC)) ;
 
        regs->maccfg1 &= ~(MACCFG1_TX_EN | MACCFG1_RX_EN);
 
@@ -988,11 +1096,11 @@ static void tsec_halt(struct eth_device *dev)
                phy_run_commands(priv, priv->phyinfo->shutdown);
 }
 
-struct phy_info phy_info_M88E1149S = {
+static struct phy_info phy_info_M88E1149S = {
        0x1410ca,
        "Marvell 88E1149S",
        4,
-       (struct phy_cmd[]){     /* config */
+       (struct phy_cmd[]) {     /* config */
                /* Reset and configure the PHY */
                {MIIM_CONTROL, MIIM_CONTROL_RESET, NULL},
                {0x1d, 0x1f, NULL},
@@ -1006,23 +1114,22 @@ struct phy_info phy_info_M88E1149S = {
                {MIIM_CONTROL, MIIM_CONTROL_INIT, &mii_cr_init},
                {miim_end,}
        },
-       (struct phy_cmd[]){     /* startup */
+       (struct phy_cmd[]) {     /* startup */
                /* Status is read once to clear old link state */
                {MIIM_STATUS, miim_read, NULL},
                /* Auto-negotiate */
                {MIIM_STATUS, miim_read, &mii_parse_sr},
                /* Read the status */
-               {MIIM_88E1011_PHY_STATUS, miim_read,
-                &mii_parse_88E1011_psr},
+               {MIIM_88E1011_PHY_STATUS, miim_read, &mii_parse_88E1011_psr},
                {miim_end,}
        },
-       (struct phy_cmd[]){     /* shutdown */
+       (struct phy_cmd[]) {     /* shutdown */
                {miim_end,}
        },
 };
 
 /* The 5411 id is 0x206070, the 5421 is 0x2060e0 */
-struct phy_info phy_info_BCM5461S = {
+static struct phy_info phy_info_BCM5461S = {
        0x02060c1,      /* 5461 ID */
        "Broadcom BCM5461S",
        0, /* not clear to me what minor revisions we can shift away */
@@ -1049,7 +1156,7 @@ struct phy_info phy_info_BCM5461S = {
        },
 };
 
-struct phy_info phy_info_BCM5464S = {
+static struct phy_info phy_info_BCM5464S = {
        0x02060b1,      /* 5464 ID */
        "Broadcom BCM5464S",
        0, /* not clear to me what minor revisions we can shift away */
@@ -1076,7 +1183,7 @@ struct phy_info phy_info_BCM5464S = {
        },
 };
 
-struct phy_info phy_info_BCM5482S =  {
+static struct phy_info phy_info_BCM5482S =  {
        0x0143bcb,
        "Broadcom BCM5482S",
        4,
@@ -1088,15 +1195,20 @@ struct phy_info phy_info_BCM5482S =  {
                /* Read Misc Control register and or in Ethernet@Wirespeed */
                {MIIM_BCM54xx_AUXCNTL, 0, &mii_BCM54xx_wirespeed},
                {MIIM_CONTROL, MIIM_CONTROL_INIT, &mii_cr_init},
+               /* Initial config/enable of secondary SerDes interface */
+               {MIIM_BCM54XX_SHD, MIIM_BCM54XX_SHD_WR_ENCODE(0x14, 0xf), NULL},
+               /* Write intial value to secondary SerDes Contol */
+               {MIIM_BCM54XX_EXP_SEL, MIIM_BCM54XX_EXP_SEL_SSD | 0, NULL},
+               {MIIM_BCM54XX_EXP_DATA, MIIM_CONTROL_RESTART, NULL},
+               /* Enable copper/fiber auto-detect */
+               {MIIM_BCM54XX_SHD, MIIM_BCM54XX_SHD_WR_ENCODE(0x1e, 0x201)},
                {miim_end,}
        },
        (struct phy_cmd[]) { /* startup */
                /* Status is read once to clear old link state */
                {MIIM_STATUS, miim_read, NULL},
-               /* Auto-negotiate */
-               {MIIM_STATUS, miim_read, &mii_parse_sr},
-               /* Read the status */
-               {MIIM_BCM54xx_AUXSTATUS, miim_read, &mii_parse_BCM54xx_sr},
+               /* Determine copper/fiber, auto-negotiate, and read the result */
+               {MIIM_STATUS, miim_read, &mii_parse_BCM5482_sr},
                {miim_end,}
        },
        (struct phy_cmd[]) { /* shutdown */
@@ -1104,74 +1216,72 @@ struct phy_info phy_info_BCM5482S =  {
        },
 };
 
-struct phy_info phy_info_M88E1011S = {
+static struct phy_info phy_info_M88E1011S = {
        0x01410c6,
        "Marvell 88E1011S",
        4,
-       (struct phy_cmd[]){     /* config */
-                          /* Reset and configure the PHY */
-                          {MIIM_CONTROL, MIIM_CONTROL_RESET, NULL},
-                          {0x1d, 0x1f, NULL},
-                          {0x1e, 0x200c, NULL},
-                          {0x1d, 0x5, NULL},
-                          {0x1e, 0x0, NULL},
-                          {0x1e, 0x100, NULL},
-                          {MIIM_GBIT_CONTROL, MIIM_GBIT_CONTROL_INIT, NULL},
-                          {MIIM_ANAR, MIIM_ANAR_INIT, NULL},
-                          {MIIM_CONTROL, MIIM_CONTROL_RESET, NULL},
-                          {MIIM_CONTROL, MIIM_CONTROL_INIT, &mii_cr_init},
-                          {miim_end,}
-                          },
-       (struct phy_cmd[]){     /* startup */
-                          /* Status is read once to clear old link state */
-                          {MIIM_STATUS, miim_read, NULL},
-                          /* Auto-negotiate */
-                          {MIIM_STATUS, miim_read, &mii_parse_sr},
-                          /* Read the status */
-                          {MIIM_88E1011_PHY_STATUS, miim_read,
-                           &mii_parse_88E1011_psr},
-                          {miim_end,}
-                          },
-       (struct phy_cmd[]){     /* shutdown */
-                          {miim_end,}
-                          },
+       (struct phy_cmd[]) {    /* config */
+               /* Reset and configure the PHY */
+               {MIIM_CONTROL, MIIM_CONTROL_RESET, NULL},
+               {0x1d, 0x1f, NULL},
+               {0x1e, 0x200c, NULL},
+               {0x1d, 0x5, NULL},
+               {0x1e, 0x0, NULL},
+               {0x1e, 0x100, NULL},
+               {MIIM_GBIT_CONTROL, MIIM_GBIT_CONTROL_INIT, NULL},
+               {MIIM_ANAR, MIIM_ANAR_INIT, NULL},
+               {MIIM_CONTROL, MIIM_CONTROL_RESET, NULL},
+               {MIIM_CONTROL, MIIM_CONTROL_INIT, &mii_cr_init},
+               {miim_end,}
+       },
+       (struct phy_cmd[]) {    /* startup */
+               /* Status is read once to clear old link state */
+               {MIIM_STATUS, miim_read, NULL},
+               /* Auto-negotiate */
+               {MIIM_STATUS, miim_read, &mii_parse_sr},
+               /* Read the status */
+               {MIIM_88E1011_PHY_STATUS, miim_read, &mii_parse_88E1011_psr},
+               {miim_end,}
+       },
+       (struct phy_cmd[]) {    /* shutdown */
+               {miim_end,}
+       },
 };
 
-struct phy_info phy_info_M88E1111S = {
+static struct phy_info phy_info_M88E1111S = {
        0x01410cc,
        "Marvell 88E1111S",
        4,
-       (struct phy_cmd[]){     /* config */
-                          /* Reset and configure the PHY */
-                          {MIIM_CONTROL, MIIM_CONTROL_RESET, NULL},
-                          {0x1b, 0x848f, &mii_m88e1111s_setmode},
-                          {0x14, 0x0cd2, NULL}, /* Delay RGMII TX and RX */
-                          {MIIM_GBIT_CONTROL, MIIM_GBIT_CONTROL_INIT, NULL},
-                          {MIIM_ANAR, MIIM_ANAR_INIT, NULL},
-                          {MIIM_CONTROL, MIIM_CONTROL_RESET, NULL},
-                          {MIIM_CONTROL, MIIM_CONTROL_INIT, &mii_cr_init},
-                          {miim_end,}
-                          },
-       (struct phy_cmd[]){     /* startup */
-                          /* Status is read once to clear old link state */
-                          {MIIM_STATUS, miim_read, NULL},
-                          /* Auto-negotiate */
-                          {MIIM_STATUS, miim_read, &mii_parse_sr},
-                          /* Read the status */
-                          {MIIM_88E1011_PHY_STATUS, miim_read,
-                           &mii_parse_88E1011_psr},
-                          {miim_end,}
-                          },
-       (struct phy_cmd[]){     /* shutdown */
-                          {miim_end,}
-                          },
+       (struct phy_cmd[]) {    /* config */
+               /* Reset and configure the PHY */
+               {MIIM_CONTROL, MIIM_CONTROL_RESET, NULL},
+               {0x1b, 0x848f, &mii_m88e1111s_setmode},
+               {0x14, 0x0cd2, NULL}, /* Delay RGMII TX and RX */
+               {MIIM_GBIT_CONTROL, MIIM_GBIT_CONTROL_INIT, NULL},
+               {MIIM_ANAR, MIIM_ANAR_INIT, NULL},
+               {MIIM_CONTROL, MIIM_CONTROL_RESET, NULL},
+               {MIIM_CONTROL, MIIM_CONTROL_INIT, &mii_cr_init},
+               {miim_end,}
+       },
+       (struct phy_cmd[]) {    /* startup */
+               /* Status is read once to clear old link state */
+               {MIIM_STATUS, miim_read, NULL},
+               /* Auto-negotiate */
+               {MIIM_STATUS, miim_read, &mii_parse_sr},
+               /* Read the status */
+               {MIIM_88E1011_PHY_STATUS, miim_read, &mii_parse_88E1011_psr},
+               {miim_end,}
+       },
+       (struct phy_cmd[]) {    /* shutdown */
+               {miim_end,}
+       },
 };
 
-struct phy_info phy_info_M88E1118 = {
+static struct phy_info phy_info_M88E1118 = {
        0x01410e1,
        "Marvell 88E1118",
        4,
-       (struct phy_cmd[])    /* config */
+       (struct phy_cmd[]) {    /* config */
                /* Reset and configure the PHY */
                {MIIM_CONTROL, MIIM_CONTROL_RESET, NULL},
                {0x16, 0x0002, NULL}, /* Change Page Number */
@@ -1184,8 +1294,8 @@ struct phy_info phy_info_M88E1118 = {
                {MIIM_CONTROL, MIIM_CONTROL_RESET, NULL},
                {MIIM_CONTROL, MIIM_CONTROL_INIT, &mii_cr_init},
                {miim_end,}
-               },
-       (struct phy_cmd[])    /* startup */
+       },
+       (struct phy_cmd[]) {    /* startup */
                {0x16, 0x0000, NULL}, /* Change Page Number */
                /* Status is read once to clear old link state */
                {MIIM_STATUS, miim_read, NULL},
@@ -1195,17 +1305,17 @@ struct phy_info phy_info_M88E1118 = {
                {MIIM_88E1011_PHY_STATUS, miim_read,
                 &mii_parse_88E1011_psr},
                {miim_end,}
-               },
-       (struct phy_cmd[])    /* shutdown */
+       },
+       (struct phy_cmd[]) {    /* shutdown */
                {miim_end,}
-               },
+       },
 };
 
 /*
  *  Since to access LED register we need do switch the page, we
  * do LED configuring in the miim_read-like function as follows
  */
-uint mii_88E1121_set_led (uint mii_reg, struct tsec_private *priv)
+static uint mii_88E1121_set_led (uint mii_reg, struct tsec_private *priv)
 {
        uint pg;
 
@@ -1222,34 +1332,33 @@ uint mii_88E1121_set_led (uint mii_reg, struct tsec_private *priv)
        return 0;
 }
 
-struct phy_info phy_info_M88E1121R = {
+static struct phy_info phy_info_M88E1121R = {
        0x01410cb,
        "Marvell 88E1121R",
        4,
-       (struct phy_cmd[]){     /* config */
-                          /* Reset and configure the PHY */
-                          {MIIM_CONTROL, MIIM_CONTROL_RESET, NULL},
-                          {MIIM_GBIT_CONTROL, MIIM_GBIT_CONTROL_INIT, NULL},
-                          {MIIM_ANAR, MIIM_ANAR_INIT, NULL},
-                          /* Configure leds */
-                          {MIIM_88E1121_PHY_LED_CTRL, miim_read,
-                           &mii_88E1121_set_led},
-                          {MIIM_CONTROL, MIIM_CONTROL_INIT, &mii_cr_init},
-                          /* Disable IRQs and de-assert interrupt */
-                          {MIIM_88E1121_PHY_IRQ_EN, 0, NULL},
-                          {MIIM_88E1121_PHY_IRQ_STATUS, miim_read, NULL},
-                          {miim_end,}
-                          },
-       (struct phy_cmd[]){     /* startup */
-                          /* Status is read once to clear old link state */
-                          {MIIM_STATUS, miim_read, NULL},
-                          {MIIM_STATUS, miim_read, &mii_parse_sr},
-                          {MIIM_STATUS, miim_read, &mii_parse_link},
-                          {miim_end,}
-                          },
-       (struct phy_cmd[]){     /* shutdown */
-                          {miim_end,}
-                          },
+       (struct phy_cmd[]) {    /* config */
+               /* Reset and configure the PHY */
+               {MIIM_CONTROL, MIIM_CONTROL_RESET, NULL},
+               {MIIM_GBIT_CONTROL, MIIM_GBIT_CONTROL_INIT, NULL},
+               {MIIM_ANAR, MIIM_ANAR_INIT, NULL},
+               /* Configure leds */
+               {MIIM_88E1121_PHY_LED_CTRL, miim_read, &mii_88E1121_set_led},
+               {MIIM_CONTROL, MIIM_CONTROL_INIT, &mii_cr_init},
+               /* Disable IRQs and de-assert interrupt */
+               {MIIM_88E1121_PHY_IRQ_EN, 0, NULL},
+               {MIIM_88E1121_PHY_IRQ_STATUS, miim_read, NULL},
+               {miim_end,}
+       },
+       (struct phy_cmd[]) {    /* startup */
+               /* Status is read once to clear old link state */
+               {MIIM_STATUS, miim_read, NULL},
+               {MIIM_STATUS, miim_read, &mii_parse_sr},
+               {MIIM_STATUS, miim_read, &mii_parse_link},
+               {miim_end,}
+       },
+       (struct phy_cmd[]) {    /* shutdown */
+               {miim_end,}
+       },
 };
 
 static unsigned int m88e1145_setmode(uint mii_reg, struct tsec_private *priv)
@@ -1268,276 +1377,283 @@ static struct phy_info phy_info_M88E1145 = {
        0x01410cd,
        "Marvell 88E1145",
        4,
-       (struct phy_cmd[]){     /* config */
-                          /* Reset the PHY */
-                          {MIIM_CONTROL, MIIM_CONTROL_RESET, NULL},
-
-                          /* Errata E0, E1 */
-                          {29, 0x001b, NULL},
-                          {30, 0x418f, NULL},
-                          {29, 0x0016, NULL},
-                          {30, 0xa2da, NULL},
-
-                          /* Configure the PHY */
-                          {MIIM_GBIT_CONTROL, MIIM_GBIT_CONTROL_INIT, NULL},
-                          {MIIM_ANAR, MIIM_ANAR_INIT, NULL},
-                          {MIIM_88E1011_PHY_SCR, MIIM_88E1011_PHY_MDI_X_AUTO,
-                           NULL},
-                          {MIIM_88E1145_PHY_EXT_CR, 0, &m88e1145_setmode},
-                          {MIIM_CONTROL, MIIM_CONTROL_RESET, NULL},
-                          {MIIM_CONTROL, MIIM_CONTROL_INIT, NULL},
-                          {miim_end,}
-                          },
-       (struct phy_cmd[]){     /* startup */
-                          /* Status is read once to clear old link state */
-                          {MIIM_STATUS, miim_read, NULL},
-                          /* Auto-negotiate */
-                          {MIIM_STATUS, miim_read, &mii_parse_sr},
-                          {MIIM_88E1111_PHY_LED_CONTROL,
-                           MIIM_88E1111_PHY_LED_DIRECT, NULL},
-                          /* Read the Status */
-                          {MIIM_88E1011_PHY_STATUS, miim_read,
-                           &mii_parse_88E1011_psr},
-                          {miim_end,}
-                          },
-       (struct phy_cmd[]){     /* shutdown */
-                          {miim_end,}
-                          },
+       (struct phy_cmd[]) {    /* config */
+               /* Reset the PHY */
+               {MIIM_CONTROL, MIIM_CONTROL_RESET, NULL},
+
+               /* Errata E0, E1 */
+               {29, 0x001b, NULL},
+               {30, 0x418f, NULL},
+               {29, 0x0016, NULL},
+               {30, 0xa2da, NULL},
+
+               /* Configure the PHY */
+               {MIIM_GBIT_CONTROL, MIIM_GBIT_CONTROL_INIT, NULL},
+               {MIIM_ANAR, MIIM_ANAR_INIT, NULL},
+               {MIIM_88E1011_PHY_SCR, MIIM_88E1011_PHY_MDI_X_AUTO, NULL},
+               {MIIM_88E1145_PHY_EXT_CR, 0, &m88e1145_setmode},
+               {MIIM_CONTROL, MIIM_CONTROL_RESET, NULL},
+               {MIIM_CONTROL, MIIM_CONTROL_INIT, NULL},
+               {miim_end,}
+       },
+       (struct phy_cmd[]) {    /* startup */
+               /* Status is read once to clear old link state */
+               {MIIM_STATUS, miim_read, NULL},
+               /* Auto-negotiate */
+               {MIIM_STATUS, miim_read, &mii_parse_sr},
+               {MIIM_88E1111_PHY_LED_CONTROL, MIIM_88E1111_PHY_LED_DIRECT, NULL},
+               /* Read the Status */
+               {MIIM_88E1011_PHY_STATUS, miim_read, &mii_parse_88E1011_psr},
+               {miim_end,}
+       },
+       (struct phy_cmd[]) {    /* shutdown */
+               {miim_end,}
+       },
 };
 
-struct phy_info phy_info_cis8204 = {
+static struct phy_info phy_info_cis8204 = {
        0x3f11,
        "Cicada Cis8204",
        6,
-       (struct phy_cmd[]){     /* config */
-                          /* Override PHY config settings */
-                          {MIIM_CIS8201_AUX_CONSTAT,
-                           MIIM_CIS8201_AUXCONSTAT_INIT, NULL},
-                          /* Configure some basic stuff */
-                          {MIIM_CONTROL, MIIM_CONTROL_INIT, &mii_cr_init},
-                          {MIIM_CIS8204_SLED_CON, MIIM_CIS8204_SLEDCON_INIT,
-                           &mii_cis8204_fixled},
-                          {MIIM_CIS8204_EPHY_CON, MIIM_CIS8204_EPHYCON_INIT,
-                           &mii_cis8204_setmode},
-                          {miim_end,}
-                          },
-       (struct phy_cmd[]){     /* startup */
-                          /* Read the Status (2x to make sure link is right) */
-                          {MIIM_STATUS, miim_read, NULL},
-                          /* Auto-negotiate */
-                          {MIIM_STATUS, miim_read, &mii_parse_sr},
-                          /* Read the status */
-                          {MIIM_CIS8201_AUX_CONSTAT, miim_read,
-                           &mii_parse_cis8201},
-                          {miim_end,}
-                          },
-       (struct phy_cmd[]){     /* shutdown */
-                          {miim_end,}
-                          },
+       (struct phy_cmd[]) {    /* config */
+               /* Override PHY config settings */
+               {MIIM_CIS8201_AUX_CONSTAT, MIIM_CIS8201_AUXCONSTAT_INIT, NULL},
+               /* Configure some basic stuff */
+               {MIIM_CONTROL, MIIM_CONTROL_INIT, &mii_cr_init},
+               {MIIM_CIS8204_SLED_CON, MIIM_CIS8204_SLEDCON_INIT,
+                &mii_cis8204_fixled},
+               {MIIM_CIS8204_EPHY_CON, MIIM_CIS8204_EPHYCON_INIT,
+                &mii_cis8204_setmode},
+               {miim_end,}
+       },
+       (struct phy_cmd[]) {    /* startup */
+               /* Read the Status (2x to make sure link is right) */
+               {MIIM_STATUS, miim_read, NULL},
+               /* Auto-negotiate */
+               {MIIM_STATUS, miim_read, &mii_parse_sr},
+               /* Read the status */
+               {MIIM_CIS8201_AUX_CONSTAT, miim_read, &mii_parse_cis8201},
+               {miim_end,}
+       },
+       (struct phy_cmd[]) {    /* shutdown */
+               {miim_end,}
+       },
 };
 
 /* Cicada 8201 */
-struct phy_info phy_info_cis8201 = {
+static struct phy_info phy_info_cis8201 = {
        0xfc41,
        "CIS8201",
        4,
-       (struct phy_cmd[]){     /* config */
-                          /* Override PHY config settings */
-                          {MIIM_CIS8201_AUX_CONSTAT,
-                           MIIM_CIS8201_AUXCONSTAT_INIT, NULL},
-                          /* Set up the interface mode */
-                          {MIIM_CIS8201_EXT_CON1, MIIM_CIS8201_EXTCON1_INIT,
-                           NULL},
-                          /* Configure some basic stuff */
-                          {MIIM_CONTROL, MIIM_CONTROL_INIT, &mii_cr_init},
-                          {miim_end,}
-                          },
-       (struct phy_cmd[]){     /* startup */
-                          /* Read the Status (2x to make sure link is right) */
-                          {MIIM_STATUS, miim_read, NULL},
-                          /* Auto-negotiate */
-                          {MIIM_STATUS, miim_read, &mii_parse_sr},
-                          /* Read the status */
-                          {MIIM_CIS8201_AUX_CONSTAT, miim_read,
-                           &mii_parse_cis8201},
-                          {miim_end,}
-                          },
-       (struct phy_cmd[]){     /* shutdown */
-                          {miim_end,}
-                          },
+       (struct phy_cmd[]) {    /* config */
+               /* Override PHY config settings */
+               {MIIM_CIS8201_AUX_CONSTAT, MIIM_CIS8201_AUXCONSTAT_INIT, NULL},
+               /* Set up the interface mode */
+               {MIIM_CIS8201_EXT_CON1, MIIM_CIS8201_EXTCON1_INIT, NULL},
+               /* Configure some basic stuff */
+               {MIIM_CONTROL, MIIM_CONTROL_INIT, &mii_cr_init},
+               {miim_end,}
+       },
+       (struct phy_cmd[]) {    /* startup */
+               /* Read the Status (2x to make sure link is right) */
+               {MIIM_STATUS, miim_read, NULL},
+               /* Auto-negotiate */
+               {MIIM_STATUS, miim_read, &mii_parse_sr},
+               /* Read the status */
+               {MIIM_CIS8201_AUX_CONSTAT, miim_read, &mii_parse_cis8201},
+               {miim_end,}
+       },
+       (struct phy_cmd[]) {    /* shutdown */
+               {miim_end,}
+       },
 };
-struct phy_info phy_info_VSC8211 = {
+
+static struct phy_info phy_info_VSC8211 = {
        0xfc4b,
        "Vitesse VSC8211",
        4,
        (struct phy_cmd[]) { /* config */
-                          /* Override PHY config settings */
-                          {MIIM_CIS8201_AUX_CONSTAT,
-                           MIIM_CIS8201_AUXCONSTAT_INIT, NULL},
-                          /* Set up the interface mode */
-                          {MIIM_CIS8201_EXT_CON1,
-                           MIIM_CIS8201_EXTCON1_INIT, NULL},
-                          /* Configure some basic stuff */
-                          {MIIM_CONTROL, MIIM_CONTROL_INIT, &mii_cr_init},
-                          {miim_end,}
-                          },
+               /* Override PHY config settings */
+               {MIIM_CIS8201_AUX_CONSTAT, MIIM_CIS8201_AUXCONSTAT_INIT, NULL},
+               /* Set up the interface mode */
+               {MIIM_CIS8201_EXT_CON1, MIIM_CIS8201_EXTCON1_INIT, NULL},
+               /* Configure some basic stuff */
+               {MIIM_CONTROL, MIIM_CONTROL_INIT, &mii_cr_init},
+               {miim_end,}
+       },
        (struct phy_cmd[]) { /* startup */
-                          /* Read the Status (2x to make sure link is right) */
-                          {MIIM_STATUS, miim_read, NULL},
-                          /* Auto-negotiate */
-                          {MIIM_STATUS, miim_read, &mii_parse_sr},
-                          /* Read the status */
-                          {MIIM_CIS8201_AUX_CONSTAT, miim_read,
-                           &mii_parse_cis8201},
-                          {miim_end,}
-                          },
+               /* Read the Status (2x to make sure link is right) */
+               {MIIM_STATUS, miim_read, NULL},
+               /* Auto-negotiate */
+               {MIIM_STATUS, miim_read, &mii_parse_sr},
+               /* Read the status */
+               {MIIM_CIS8201_AUX_CONSTAT, miim_read, &mii_parse_cis8201},
+               {miim_end,}
+       },
        (struct phy_cmd[]) { /* shutdown */
-                          {miim_end,}
+               {miim_end,}
        },
 };
-struct phy_info phy_info_VSC8244 = {
+
+static struct phy_info phy_info_VSC8244 = {
        0x3f1b,
        "Vitesse VSC8244",
        6,
-       (struct phy_cmd[]){     /* config */
-                          /* Override PHY config settings */
-                          /* Configure some basic stuff */
-                          {MIIM_CONTROL, MIIM_CONTROL_INIT, &mii_cr_init},
-                          {miim_end,}
-                          },
-       (struct phy_cmd[]){     /* startup */
-                          /* Read the Status (2x to make sure link is right) */
-                          {MIIM_STATUS, miim_read, NULL},
-                          /* Auto-negotiate */
-                          {MIIM_STATUS, miim_read, &mii_parse_sr},
-                          /* Read the status */
-                          {MIIM_VSC8244_AUX_CONSTAT, miim_read,
-                           &mii_parse_vsc8244},
-                          {miim_end,}
-                          },
-       (struct phy_cmd[]){     /* shutdown */
-                          {miim_end,}
-                          },
+       (struct phy_cmd[]) {    /* config */
+               /* Override PHY config settings */
+               /* Configure some basic stuff */
+               {MIIM_CONTROL, MIIM_CONTROL_INIT, &mii_cr_init},
+               {miim_end,}
+       },
+       (struct phy_cmd[]) {    /* startup */
+               /* Read the Status (2x to make sure link is right) */
+               {MIIM_STATUS, miim_read, NULL},
+               /* Auto-negotiate */
+               {MIIM_STATUS, miim_read, &mii_parse_sr},
+               /* Read the status */
+               {MIIM_VSC8244_AUX_CONSTAT, miim_read, &mii_parse_vsc8244},
+               {miim_end,}
+       },
+       (struct phy_cmd[]) {    /* shutdown */
+               {miim_end,}
+       },
 };
 
-struct phy_info phy_info_VSC8641 = {
+static struct phy_info phy_info_VSC8641 = {
        0x7043,
        "Vitesse VSC8641",
        4,
-       (struct phy_cmd[]){     /* config */
-                          /* Configure some basic stuff */
-                          {MIIM_CONTROL, MIIM_CONTROL_INIT, &mii_cr_init},
-                          {miim_end,}
-                          },
-       (struct phy_cmd[]){     /* startup */
-                          /* Read the Status (2x to make sure link is right) */
-                          {MIIM_STATUS, miim_read, NULL},
-                          /* Auto-negotiate */
-                          {MIIM_STATUS, miim_read, &mii_parse_sr},
-                          /* Read the status */
-                          {MIIM_VSC8244_AUX_CONSTAT, miim_read,
-                           &mii_parse_vsc8244},
-                          {miim_end,}
-                          },
-       (struct phy_cmd[]){     /* shutdown */
-                          {miim_end,}
-                          },
+       (struct phy_cmd[]) {    /* config */
+               /* Configure some basic stuff */
+               {MIIM_CONTROL, MIIM_CONTROL_INIT, &mii_cr_init},
+               {miim_end,}
+       },
+       (struct phy_cmd[]) {    /* startup */
+               /* Read the Status (2x to make sure link is right) */
+               {MIIM_STATUS, miim_read, NULL},
+               /* Auto-negotiate */
+               {MIIM_STATUS, miim_read, &mii_parse_sr},
+               /* Read the status */
+               {MIIM_VSC8244_AUX_CONSTAT, miim_read, &mii_parse_vsc8244},
+               {miim_end,}
+       },
+       (struct phy_cmd[]) {    /* shutdown */
+               {miim_end,}
+       },
 };
 
-struct phy_info phy_info_VSC8221 = {
+static struct phy_info phy_info_VSC8221 = {
        0xfc55,
        "Vitesse VSC8221",
        4,
-       (struct phy_cmd[]){     /* config */
-                          /* Configure some basic stuff */
-                          {MIIM_CONTROL, MIIM_CONTROL_INIT, &mii_cr_init},
-                          {miim_end,}
-                          },
-       (struct phy_cmd[]){     /* startup */
-                          /* Read the Status (2x to make sure link is right) */
-                          {MIIM_STATUS, miim_read, NULL},
-                          /* Auto-negotiate */
-                          {MIIM_STATUS, miim_read, &mii_parse_sr},
-                          /* Read the status */
-                          {MIIM_VSC8244_AUX_CONSTAT, miim_read,
-                           &mii_parse_vsc8244},
-                          {miim_end,}
-                          },
-       (struct phy_cmd[]){     /* shutdown */
-                          {miim_end,}
-                          },
+       (struct phy_cmd[]) {    /* config */
+               /* Configure some basic stuff */
+               {MIIM_CONTROL, MIIM_CONTROL_INIT, &mii_cr_init},
+               {miim_end,}
+       },
+       (struct phy_cmd[]) {    /* startup */
+               /* Read the Status (2x to make sure link is right) */
+               {MIIM_STATUS, miim_read, NULL},
+               /* Auto-negotiate */
+               {MIIM_STATUS, miim_read, &mii_parse_sr},
+               /* Read the status */
+               {MIIM_VSC8244_AUX_CONSTAT, miim_read, &mii_parse_vsc8244},
+               {miim_end,}
+       },
+       (struct phy_cmd[]) {    /* shutdown */
+               {miim_end,}
+       },
 };
 
-struct phy_info phy_info_VSC8601 = {
-               0x00007042,
-               "Vitesse VSC8601",
-               4,
-               (struct phy_cmd[]){     /* config */
-                               /* Override PHY config settings */
-                               /* Configure some basic stuff */
-                               {MIIM_CONTROL, MIIM_CONTROL_INIT, &mii_cr_init},
+static struct phy_info phy_info_VSC8601 = {
+       0x00007042,
+       "Vitesse VSC8601",
+       4,
+       (struct phy_cmd[]) {     /* config */
+               /* Override PHY config settings */
+               /* Configure some basic stuff */
+               {MIIM_CONTROL, MIIM_CONTROL_INIT, &mii_cr_init},
 #ifdef CONFIG_SYS_VSC8601_SKEWFIX
-                               {MIIM_VSC8601_EPHY_CON,MIIM_VSC8601_EPHY_CON_INIT_SKEW,NULL},
+               {MIIM_VSC8601_EPHY_CON,MIIM_VSC8601_EPHY_CON_INIT_SKEW,NULL},
 #if defined(CONFIG_SYS_VSC8601_SKEW_TX) && defined(CONFIG_SYS_VSC8601_SKEW_RX)
-                               {MIIM_EXT_PAGE_ACCESS,1,NULL},
-#define VSC8101_SKEW   (CONFIG_SYS_VSC8601_SKEW_TX<<14)|(CONFIG_SYS_VSC8601_SKEW_RX<<12)
-                               {MIIM_VSC8601_SKEW_CTRL,VSC8101_SKEW,NULL},
-                               {MIIM_EXT_PAGE_ACCESS,0,NULL},
+               {MIIM_EXT_PAGE_ACCESS,1,NULL},
+#define VSC8101_SKEW \
+       (CONFIG_SYS_VSC8601_SKEW_TX << 14) | (CONFIG_SYS_VSC8601_SKEW_RX << 12)
+               {MIIM_VSC8601_SKEW_CTRL,VSC8101_SKEW,NULL},
+               {MIIM_EXT_PAGE_ACCESS,0,NULL},
 #endif
 #endif
-                               {MIIM_ANAR, MIIM_ANAR_INIT, NULL},
-                               {MIIM_CONTROL, MIIM_CONTROL_RESTART, &mii_cr_init},
-                               {miim_end,}
-                                },
-               (struct phy_cmd[]){     /* startup */
-                               /* Read the Status (2x to make sure link is right) */
-                               {MIIM_STATUS, miim_read, NULL},
-                               /* Auto-negotiate */
-                               {MIIM_STATUS, miim_read, &mii_parse_sr},
-                               /* Read the status */
-                               {MIIM_VSC8244_AUX_CONSTAT, miim_read,
-                                               &mii_parse_vsc8244},
-                               {miim_end,}
-                               },
-               (struct phy_cmd[]){     /* shutdown */
-                               {miim_end,}
-                               },
+               {MIIM_ANAR, MIIM_ANAR_INIT, NULL},
+               {MIIM_CONTROL, MIIM_CONTROL_RESTART, &mii_cr_init},
+               {miim_end,}
+       },
+       (struct phy_cmd[]) {     /* startup */
+               /* Read the Status (2x to make sure link is right) */
+               {MIIM_STATUS, miim_read, NULL},
+               /* Auto-negotiate */
+               {MIIM_STATUS, miim_read, &mii_parse_sr},
+               /* Read the status */
+               {MIIM_VSC8244_AUX_CONSTAT, miim_read, &mii_parse_vsc8244},
+               {miim_end,}
+       },
+       (struct phy_cmd[]) {     /* shutdown */
+               {miim_end,}
+       },
 };
 
-
-struct phy_info phy_info_dm9161 = {
+static struct phy_info phy_info_dm9161 = {
        0x0181b88,
        "Davicom DM9161E",
        4,
-       (struct phy_cmd[]){     /* config */
-                          {MIIM_CONTROL, MIIM_DM9161_CR_STOP, NULL},
-                          /* Do not bypass the scrambler/descrambler */
-                          {MIIM_DM9161_SCR, MIIM_DM9161_SCR_INIT, NULL},
-                          /* Clear 10BTCSR to default */
-                          {MIIM_DM9161_10BTCSR, MIIM_DM9161_10BTCSR_INIT,
-                           NULL},
-                          /* Configure some basic stuff */
-                          {MIIM_CONTROL, MIIM_CR_INIT, NULL},
-                          /* Restart Auto Negotiation */
-                          {MIIM_CONTROL, MIIM_DM9161_CR_RSTAN, NULL},
-                          {miim_end,}
-                          },
-       (struct phy_cmd[]){     /* startup */
-                          /* Status is read once to clear old link state */
-                          {MIIM_STATUS, miim_read, NULL},
-                          /* Auto-negotiate */
-                          {MIIM_STATUS, miim_read, &mii_parse_sr},
-                          /* Read the status */
-                          {MIIM_DM9161_SCSR, miim_read,
-                           &mii_parse_dm9161_scsr},
-                          {miim_end,}
-                          },
-       (struct phy_cmd[]){     /* shutdown */
-                          {miim_end,}
-                          },
+       (struct phy_cmd[]) {    /* config */
+               {MIIM_CONTROL, MIIM_DM9161_CR_STOP, NULL},
+               /* Do not bypass the scrambler/descrambler */
+               {MIIM_DM9161_SCR, MIIM_DM9161_SCR_INIT, NULL},
+               /* Clear 10BTCSR to default */
+               {MIIM_DM9161_10BTCSR, MIIM_DM9161_10BTCSR_INIT, NULL},
+               /* Configure some basic stuff */
+               {MIIM_CONTROL, MIIM_CR_INIT, NULL},
+               /* Restart Auto Negotiation */
+               {MIIM_CONTROL, MIIM_DM9161_CR_RSTAN, NULL},
+               {miim_end,}
+       },
+       (struct phy_cmd[]) {    /* startup */
+               /* Status is read once to clear old link state */
+               {MIIM_STATUS, miim_read, NULL},
+               /* Auto-negotiate */
+               {MIIM_STATUS, miim_read, &mii_parse_sr},
+               /* Read the status */
+               {MIIM_DM9161_SCSR, miim_read, &mii_parse_dm9161_scsr},
+               {miim_end,}
+       },
+       (struct phy_cmd[]) {    /* shutdown */
+               {miim_end,}
+       },
 };
+
+/* micrel KSZ804  */
+static struct phy_info phy_info_ksz804 =  {
+       0x0022151,
+       "Micrel KSZ804 PHY",
+       4,
+       (struct phy_cmd[]) { /* config */
+               {PHY_BMCR, PHY_BMCR_RESET, NULL},
+               {PHY_BMCR, PHY_BMCR_AUTON|PHY_BMCR_RST_NEG, NULL},
+               {miim_end,}
+       },
+       (struct phy_cmd[]) { /* startup */
+               {PHY_BMSR, miim_read, NULL},
+               {PHY_BMSR, miim_read, &mii_parse_sr},
+               {PHY_BMSR, miim_read, &mii_parse_link},
+               {miim_end,}
+       },
+       (struct phy_cmd[]) { /* shutdown */
+               {miim_end,}
+       }
+};
+
 /* a generic flavor.  */
-struct phy_info phy_info_generic =  {
+static struct phy_info phy_info_generic =  {
        0,
        "Unknown/Generic PHY",
        32,
@@ -1557,8 +1673,7 @@ struct phy_info phy_info_generic =  {
        }
 };
 
-
-uint mii_parse_lxt971_sr2(uint mii_reg, struct tsec_private *priv)
+static uint mii_parse_lxt971_sr2(uint mii_reg, struct tsec_private *priv)
 {
        unsigned int speed;
        if (priv->link) {
@@ -1593,26 +1708,26 @@ static struct phy_info phy_info_lxt971 = {
        0x0001378e,
        "LXT971",
        4,
-       (struct phy_cmd[])    /* config */
-                          {MIIM_CR, MIIM_CR_INIT, mii_cr_init},        /* autonegotiate */
-                          {miim_end,}
-                          },
-       (struct phy_cmd[])    /* startup - enable interrupts */
-                          /* { 0x12, 0x00f2, NULL }, */
-                          {MIIM_STATUS, miim_read, NULL},
-                          {MIIM_STATUS, miim_read, &mii_parse_sr},
-                          {MIIM_LXT971_SR2, miim_read, &mii_parse_lxt971_sr2},
-                          {miim_end,}
-                          },
-       (struct phy_cmd[])    /* shutdown - disable interrupts */
-                          {miim_end,}
-                          },
+       (struct phy_cmd[]) {    /* config */
+               {MIIM_CR, MIIM_CR_INIT, mii_cr_init},   /* autonegotiate */
+               {miim_end,}
+       },
+       (struct phy_cmd[]) {    /* startup - enable interrupts */
+               /* { 0x12, 0x00f2, NULL }, */
+               {MIIM_STATUS, miim_read, NULL},
+               {MIIM_STATUS, miim_read, &mii_parse_sr},
+               {MIIM_LXT971_SR2, miim_read, &mii_parse_lxt971_sr2},
+               {miim_end,}
+       },
+       (struct phy_cmd[]) {    /* shutdown - disable interrupts */
+               {miim_end,}
+       },
 };
 
 /* Parse the DP83865's link and auto-neg status register for speed and duplex
  * information
  */
-uint mii_parse_dp83865_lanr(uint mii_reg, struct tsec_private *priv)
+static uint mii_parse_dp83865_lanr(uint mii_reg, struct tsec_private *priv)
 {
        switch (mii_reg & MIIM_DP83865_SPD_MASK) {
 
@@ -1638,34 +1753,33 @@ uint mii_parse_dp83865_lanr(uint mii_reg, struct tsec_private *priv)
        return 0;
 }
 
-struct phy_info phy_info_dp83865 = {
+static struct phy_info phy_info_dp83865 = {
        0x20005c7,
        "NatSemi DP83865",
        4,
-       (struct phy_cmd[]){     /* config */
-                          {MIIM_CONTROL, MIIM_DP83865_CR_INIT, NULL},
-                          {miim_end,}
-                          },
-       (struct phy_cmd[]){     /* startup */
-                          /* Status is read once to clear old link state */
-                          {MIIM_STATUS, miim_read, NULL},
-                          /* Auto-negotiate */
-                          {MIIM_STATUS, miim_read, &mii_parse_sr},
-                          /* Read the link and auto-neg status */
-                          {MIIM_DP83865_LANR, miim_read,
-                           &mii_parse_dp83865_lanr},
-                          {miim_end,}
-                          },
-       (struct phy_cmd[]){     /* shutdown */
-                          {miim_end,}
-                          },
+       (struct phy_cmd[]) {    /* config */
+               {MIIM_CONTROL, MIIM_DP83865_CR_INIT, NULL},
+               {miim_end,}
+       },
+       (struct phy_cmd[]) {    /* startup */
+               /* Status is read once to clear old link state */
+               {MIIM_STATUS, miim_read, NULL},
+               /* Auto-negotiate */
+               {MIIM_STATUS, miim_read, &mii_parse_sr},
+               /* Read the link and auto-neg status */
+               {MIIM_DP83865_LANR, miim_read, &mii_parse_dp83865_lanr},
+               {miim_end,}
+       },
+       (struct phy_cmd[]) {    /* shutdown */
+               {miim_end,}
+       },
 };
 
-struct phy_info phy_info_rtl8211b = {
+static struct phy_info phy_info_rtl8211b = {
        0x001cc91,
        "RealTek RTL8211B",
        4,
-       (struct phy_cmd[])    /* config */
+       (struct phy_cmd[]) {    /* config */
                /* Reset and configure the PHY */
                {MIIM_CONTROL, MIIM_CONTROL_RESET, NULL},
                {MIIM_GBIT_CONTROL, MIIM_GBIT_CONTROL_INIT, NULL},
@@ -1674,7 +1788,7 @@ struct phy_info phy_info_rtl8211b = {
                {MIIM_CONTROL, MIIM_CONTROL_INIT, &mii_cr_init},
                {miim_end,}
        },
-       (struct phy_cmd[])    /* startup */
+       (struct phy_cmd[]) {    /* startup */
                /* Status is read once to clear old link state */
                {MIIM_STATUS, miim_read, NULL},
                /* Auto-negotiate */
@@ -1683,12 +1797,12 @@ struct phy_info phy_info_rtl8211b = {
                {MIIM_RTL8211B_PHY_STATUS, miim_read, &mii_parse_RTL8211B_sr},
                {miim_end,}
        },
-       (struct phy_cmd[])    /* shutdown */
+       (struct phy_cmd[]) {    /* shutdown */
                {miim_end,}
        },
 };
 
-struct phy_info *phy_info[] = {
+static struct phy_info *phy_info[] = {
        &phy_info_cis8204,
        &phy_info_cis8201,
        &phy_info_BCM5461S,
@@ -1701,6 +1815,7 @@ struct phy_info *phy_info[] = {
        &phy_info_M88E1145,
        &phy_info_M88E1149S,
        &phy_info_dm9161,
+       &phy_info_ksz804,
        &phy_info_lxt971,
        &phy_info_VSC8211,
        &phy_info_VSC8244,
@@ -1717,7 +1832,7 @@ struct phy_info *phy_info[] = {
  * all of the known PHYs to see if one matches.         If so, return
  * it, if not, return NULL
  */
-struct phy_info *get_phy_info(struct eth_device *dev)
+static struct phy_info *get_phy_info(struct eth_device *dev)
 {
        struct tsec_private *priv = (struct tsec_private *)dev->priv;
        uint phy_reg, phy_ID;
@@ -1742,7 +1857,8 @@ struct phy_info *get_phy_info(struct eth_device *dev)
        }
 
        if (theInfo == &phy_info_generic) {
-               printf("%s: No support for PHY id %x; assuming generic\n", dev->name, phy_ID);
+               printf("%s: No support for PHY id %x; assuming generic\n",
+                       dev->name, phy_ID);
        } else {
                debug("%s: PHY is %s (%x)\n", dev->name, theInfo->name, phy_ID);
        }
@@ -1753,7 +1869,7 @@ struct phy_info *get_phy_info(struct eth_device *dev)
 /* Execute the given series of commands on the given device's
  * PHY, running functions as necessary
  */
-void phy_run_commands(struct tsec_private *priv, struct phy_cmd *cmd)
+static void phy_run_commands(struct tsec_private *priv, struct phy_cmd *cmd)
 {
        int i;
        uint result;
@@ -1855,10 +1971,10 @@ static int tsec_miiphy_write(char *devname, unsigned char addr,
 static int
 tsec_mcast_addr (struct eth_device *dev, u8 mcast_mac, u8 set)
 {
- struct tsec_private *priv = privlist[1];
- volatile tsec_t *regs = priv->regs;
- volatile u32  *reg_array, value;
- u8 result, whichbit, whichreg;
      struct tsec_private *priv = privlist[1];
      volatile tsec_t *regs = priv->regs;
      volatile u32  *reg_array, value;
      u8 result, whichbit, whichreg;
 
        result = (u8)((ether_crc(MAC_ADDR_LEN,mcast_mac) >> 24) & 0xff);
        whichbit = result & 0x1f;       /* the 5 LSB = which bit to set */