]> git.kernelconcepts.de Git - karo-tx-linux.git/blobdiff - tools/perf/util/sort.c
perf tools: Add overhead/overhead_children keys defaults via string
[karo-tx-linux.git] / tools / perf / util / sort.c
index f3a98c25fb8d9090db0eb50c09f2cd6d587125c9..ec722346e6ffb8dd6531e94576bb15b548a1487b 100644 (file)
@@ -15,6 +15,7 @@ const char    default_branch_sort_order[] = "comm,dso_from,symbol_from,symbol_to,cy
 const char     default_mem_sort_order[] = "local_weight,mem,sym,dso,symbol_daddr,dso_daddr,snoop,tlb,locked";
 const char     default_top_sort_order[] = "dso,symbol";
 const char     default_diff_sort_order[] = "dso,symbol";
+const char     default_tracepoint_sort_order[] = "trace";
 const char     *sort_order;
 const char     *field_order;
 regex_t                ignore_callees_regex;
@@ -1698,6 +1699,15 @@ static int __sort__hde_width(struct perf_hpp_fmt *fmt,
        return len;
 }
 
+bool perf_hpp__defined_dynamic_entry(struct perf_hpp_fmt *fmt, struct hists *hists)
+{
+       struct hpp_dynamic_entry *hde;
+
+       hde = container_of(fmt, struct hpp_dynamic_entry, hpp);
+
+       return hists_to_evsel(hists) == hde->evsel;
+}
+
 static int __sort__hde_entry(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp,
                             struct hist_entry *he)
 {
@@ -1714,9 +1724,6 @@ static int __sort__hde_entry(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp,
        if (!len)
                len = hde_width(hde);
 
-       if (hists_to_evsel(he->hists) != hde->evsel)
-               return scnprintf(hpp->buf, hpp->size, "%*.*s", len, len, "N/A");
-
        if (hde->raw_trace)
                goto raw_field;
 
@@ -1769,9 +1776,6 @@ static int64_t __sort__hde_cmp(struct perf_hpp_fmt *fmt,
 
        hde = container_of(fmt, struct hpp_dynamic_entry, hpp);
 
-       if (hists_to_evsel(a->hists) != hde->evsel)
-               return 0;
-
        field = hde->field;
        if (field->flags & FIELD_IS_DYNAMIC) {
                unsigned long long dyn;
@@ -1794,6 +1798,11 @@ static int64_t __sort__hde_cmp(struct perf_hpp_fmt *fmt,
        return memcmp(a->raw_data + offset, b->raw_data + offset, size);
 }
 
+bool perf_hpp__is_dynamic_entry(struct perf_hpp_fmt *fmt)
+{
+       return fmt->cmp == __sort__hde_cmp;
+}
+
 static struct hpp_dynamic_entry *
 __alloc_dynamic_entry(struct perf_evsel *evsel, struct format_field *field)
 {
@@ -1854,10 +1863,9 @@ static int parse_field_name(char *str, char **event, char **field, char **opt)
 }
 
 /* find match evsel using a given event name.  The event name can be:
- *   1. NULL - only valid for single event session
- *   2. '%' + event index (e.g. '%1' for first event)
- *   3. full event name (e.g. sched:sched_switch)
- *   4. partial event name (should not contain ':')
+ *   1. '%' + event index (e.g. '%1' for first event)
+ *   2. full event name (e.g. sched:sched_switch)
+ *   3. partial event name (should not contain ':')
  */
 static struct perf_evsel *find_evsel(struct perf_evlist *evlist, char *event_name)
 {
@@ -1866,16 +1874,6 @@ static struct perf_evsel *find_evsel(struct perf_evlist *evlist, char *event_nam
        bool full_name;
 
        /* case 1 */
-       if (event_name == NULL) {
-               if (evlist->nr_entries != 1) {
-                       pr_debug("event name should be given\n");
-                       return NULL;
-               }
-
-               return perf_evlist__first(evlist);
-       }
-
-       /* case 2 */
        if (event_name[0] == '%') {
                int nr = strtol(event_name+1, NULL, 0);
 
@@ -1891,10 +1889,10 @@ static struct perf_evsel *find_evsel(struct perf_evlist *evlist, char *event_nam
 
        full_name = !!strchr(event_name, ':');
        evlist__for_each(evlist, pos) {
-               /* case 3 */
+               /* case 2 */
                if (full_name && !strcmp(pos->name, event_name))
                        return pos;
-               /* case 4 */
+               /* case 3 */
                if (!full_name && strstr(pos->name, event_name)) {
                        if (evsel) {
                                pr_debug("'%s' event is ambiguous: it can be %s or %s\n",
@@ -1908,12 +1906,81 @@ static struct perf_evsel *find_evsel(struct perf_evlist *evlist, char *event_nam
        return evsel;
 }
 
+static int __dynamic_dimension__add(struct perf_evsel *evsel,
+                                   struct format_field *field,
+                                   bool raw_trace)
+{
+       struct hpp_dynamic_entry *hde;
+
+       hde = __alloc_dynamic_entry(evsel, field);
+       if (hde == NULL)
+               return -ENOMEM;
+
+       hde->raw_trace = raw_trace;
+
+       perf_hpp__register_sort_field(&hde->hpp);
+       return 0;
+}
+
+static int add_evsel_fields(struct perf_evsel *evsel, bool raw_trace)
+{
+       int ret;
+       struct format_field *field;
+
+       field = evsel->tp_format->format.fields;
+       while (field) {
+               ret = __dynamic_dimension__add(evsel, field, raw_trace);
+               if (ret < 0)
+                       return ret;
+
+               field = field->next;
+       }
+       return 0;
+}
+
+static int add_all_dynamic_fields(struct perf_evlist *evlist, bool raw_trace)
+{
+       int ret;
+       struct perf_evsel *evsel;
+
+       evlist__for_each(evlist, evsel) {
+               if (evsel->attr.type != PERF_TYPE_TRACEPOINT)
+                       continue;
+
+               ret = add_evsel_fields(evsel, raw_trace);
+               if (ret < 0)
+                       return ret;
+       }
+       return 0;
+}
+
+static int add_all_matching_fields(struct perf_evlist *evlist,
+                                  char *field_name, bool raw_trace)
+{
+       int ret = -ESRCH;
+       struct perf_evsel *evsel;
+       struct format_field *field;
+
+       evlist__for_each(evlist, evsel) {
+               if (evsel->attr.type != PERF_TYPE_TRACEPOINT)
+                       continue;
+
+               field = pevent_find_any_field(evsel->tp_format, field_name);
+               if (field == NULL)
+                       continue;
+
+               ret = __dynamic_dimension__add(evsel, field, raw_trace);
+               if (ret < 0)
+                       break;
+       }
+       return ret;
+}
+
 static int add_dynamic_entry(struct perf_evlist *evlist, const char *tok)
 {
        char *str, *event_name, *field_name, *opt_name;
        struct perf_evsel *evsel;
        struct format_field *field;
-       struct hpp_dynamic_entry *hde;
        bool raw_trace = symbol_conf.raw_trace;
        int ret = 0;
 
@@ -1938,6 +2005,16 @@ static int add_dynamic_entry(struct perf_evlist *evlist, const char *tok)
                raw_trace = true;
        }
 
+       if (!strcmp(field_name, "trace_fields")) {
+               ret = add_all_dynamic_fields(evlist, raw_trace);
+               goto out;
+       }
+
+       if (event_name == NULL) {
+               ret = add_all_matching_fields(evlist, field_name, raw_trace);
+               goto out;
+       }
+
        evsel = find_evsel(evlist, event_name);
        if (evsel == NULL) {
                pr_debug("Cannot find event: %s\n", event_name);
@@ -1951,22 +2028,18 @@ static int add_dynamic_entry(struct perf_evlist *evlist, const char *tok)
                goto out;
        }
 
-       field = pevent_find_any_field(evsel->tp_format, field_name);
-       if (field == NULL) {
-               pr_debug("Cannot find event field for %s.%s\n",
-                      event_name, field_name);
-               ret = -ENOENT;
-               goto out;
-       }
+       if (!strcmp(field_name, "*")) {
+               ret = add_evsel_fields(evsel, raw_trace);
+       } else {
+               field = pevent_find_any_field(evsel->tp_format, field_name);
+               if (field == NULL) {
+                       pr_debug("Cannot find event field for %s.%s\n",
+                                event_name, field_name);
+                       return -ENOENT;
+               }
 
-       hde = __alloc_dynamic_entry(evsel, field);
-       if (hde == NULL) {
-               ret = -ENOMEM;
-               goto out;
+               ret = __dynamic_dimension__add(evsel, field, raw_trace);
        }
-       hde->raw_trace = raw_trace;
-
-       perf_hpp__register_sort_field(&hde->hpp);
 
 out:
        free(str);
@@ -2115,7 +2188,7 @@ static int sort_dimension__add(const char *tok,
        return -ESRCH;
 }
 
-static const char *get_default_sort_order(void)
+static const char *get_default_sort_order(struct perf_evlist *evlist)
 {
        const char *default_sort_orders[] = {
                default_sort_order,
@@ -2123,14 +2196,33 @@ static const char *get_default_sort_order(void)
                default_mem_sort_order,
                default_top_sort_order,
                default_diff_sort_order,
+               default_tracepoint_sort_order,
        };
+       bool use_trace = true;
+       struct perf_evsel *evsel;
 
        BUG_ON(sort__mode >= ARRAY_SIZE(default_sort_orders));
 
+       if (evlist == NULL)
+               goto out_no_evlist;
+
+       evlist__for_each(evlist, evsel) {
+               if (evsel->attr.type != PERF_TYPE_TRACEPOINT) {
+                       use_trace = false;
+                       break;
+               }
+       }
+
+       if (use_trace) {
+               sort__mode = SORT_MODE__TRACEPOINT;
+               if (symbol_conf.raw_trace)
+                       return "trace_fields";
+       }
+out_no_evlist:
        return default_sort_orders[sort__mode];
 }
 
-static int setup_sort_order(void)
+static int setup_sort_order(struct perf_evlist *evlist)
 {
        char *new_sort_order;
 
@@ -2151,7 +2243,7 @@ static int setup_sort_order(void)
         * because it's checked over the rest of the code.
         */
        if (asprintf(&new_sort_order, "%s,%s",
-                    get_default_sort_order(), sort_order + 1) < 0) {
+                    get_default_sort_order(evlist), sort_order + 1) < 0) {
                error("Not enough memory to set up --sort");
                return -ENOMEM;
        }
@@ -2160,13 +2252,41 @@ static int setup_sort_order(void)
        return 0;
 }
 
+/*
+ * Adds 'pre,' prefix into 'str' is 'pre' is
+ * not already part of 'str'.
+ */
+static char *prefix_if_not_in(const char *pre, char *str)
+{
+       char *n;
+
+       if (!str || strstr(str, pre))
+               return str;
+
+       if (asprintf(&n, "%s,%s", pre, str) < 0)
+               return NULL;
+
+       free(str);
+       return n;
+}
+
+static char *setup_overhead(char *keys)
+{
+       keys = prefix_if_not_in("overhead", keys);
+
+       if (symbol_conf.cumulate_callchain)
+               keys = prefix_if_not_in("overhead_children", keys);
+
+       return keys;
+}
+
 static int __setup_sorting(struct perf_evlist *evlist)
 {
        char *tmp, *tok, *str;
        const char *sort_keys;
        int ret = 0;
 
-       ret = setup_sort_order();
+       ret = setup_sort_order(evlist);
        if (ret)
                return ret;
 
@@ -2180,7 +2300,7 @@ static int __setup_sorting(struct perf_evlist *evlist)
                        return 0;
                }
 
-               sort_keys = get_default_sort_order();
+               sort_keys = get_default_sort_order(evlist);
        }
 
        str = strdup(sort_keys);
@@ -2189,6 +2309,17 @@ static int __setup_sorting(struct perf_evlist *evlist)
                return -ENOMEM;
        }
 
+       /*
+        * Prepend overhead fields for backward compatibility.
+        */
+       if (!is_strict_order(field_order)) {
+               str = setup_overhead(str);
+               if (str == NULL) {
+                       error("Not enough memory to setup overhead keys");
+                       return -ENOMEM;
+               }
+       }
+
        for (tok = strtok_r(str, ", ", &tmp);
                        tok; tok = strtok_r(NULL, ", ", &tmp)) {
                ret = sort_dimension__add(tok, evlist);