]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
swap: don't do discard if no discard option added
authorShaohua Li <shli@kernel.org>
Wed, 21 Mar 2012 23:34:17 +0000 (16:34 -0700)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 30 May 2012 23:43:47 +0000 (00:43 +0100)
commit07fb30fa5b317e65a6953471886b7fd04e1acb51
tree9da224d88791c3600b03aecc57fe2cd891602dd4
parentff741084d380bd234a4d0ffba0c19e8047a14658
swap: don't do discard if no discard option added

commit 052b1987faca3606109d88d96bce124851f7c4c2 upstream.

When swapon() was not passed the SWAP_FLAG_DISCARD option, sys_swapon()
will still perform a discard operation.  This can cause problems if
discard is slow or buggy.

Reverse the order of the check so that a discard operation is performed
only if the sys_swapon() caller is attempting to enable discard.

Signed-off-by: Shaohua Li <shli@fusionio.com>
Reported-by: Holger Kiehl <Holger.Kiehl@dwd.de>
Tested-by: Holger Kiehl <Holger.Kiehl@dwd.de>
Cc: Hugh Dickins <hughd@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
mm/swapfile.c