]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
ath5k: fix error handling in ath5k_hw_dma_stop
authorBob Copeland <me@bobcopeland.com>
Tue, 25 Jan 2011 04:31:43 +0000 (23:31 -0500)
committerJohn W. Linville <linville@tuxdriver.com>
Thu, 27 Jan 2011 21:40:51 +0000 (16:40 -0500)
commit15411c27d203e363592d30ab00803254ebe77b90
tree505f58ab21ed2717fe3c67a4b444bf05bac53b6c
parentbc5892c9ec250b36c9287bd52a74d08d75a40152
ath5k: fix error handling in ath5k_hw_dma_stop

Review spotted a problem with the error handling in ath5k_hw_dma_stop:
a successful return from ath5k_hw_stop_tx_dma will be treated as
an error, so we always bail out of the loop after processing a single
active queue.  As a result, we may not actually stop some queues during
reset.

Signed-off-by: Bob Copeland <me@bobcopeland.com>
Acked-by: Bruno Randolf <br1@einfach.org>
Acked-by: Nick Kossifidis <mickflemm@gmail.com>
Reviewed-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/ath/ath5k/dma.c