]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
staging:iio:lpc32xx_adc: Ensure request_irq and free_irq dev_id parameter match
authorLars-Peter Clausen <lars@metafoo.de>
Fri, 13 Jul 2012 12:04:00 +0000 (13:04 +0100)
committerJonathan Cameron <jic23@kernel.org>
Sat, 14 Jul 2012 08:42:57 +0000 (09:42 +0100)
commit165d0c52fe87f8a95fcc01391432a659915bd332
treec31131804c5e7b3a81020ef52b6d3dbcc1140402
parent79d2a6bd14b117f140817b7d258a54bb5c963473
staging:iio:lpc32xx_adc: Ensure request_irq and free_irq dev_id parameter match

The data parameters for request_irq and free_irq have to match, otherwise the
IRQ wont be freed.

The issue has been discovered using the following coccinelle patch:

// <smpl>
@r1@
type T;
T data;
@@
(
request_irq(..., (void *)data)
|
request_irq(..., data)
|
request_threaded_irq(..., (void *)data)
|
request_threaded_irq(..., data)
)

@r2@
type r1.T;
T data;
position p;
@@
(
free_irq@p(..., (void *)data)
|
free_irq@p(..., data)
)

@depends on r1@
position p != r2.p;
@@
*free_irq@p(...)

// </smpl>

Cc: Roland Stigge <stigge@antcom.de>
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
drivers/staging/iio/adc/lpc32xx_adc.c