]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
net: mvmdio: fix interrupt timeout handling
authorLeigh Brown <leigh@solinno.co.uk>
Thu, 19 Dec 2013 13:09:48 +0000 (13:09 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 20 Dec 2013 00:20:44 +0000 (19:20 -0500)
commit1a1f20bc9debd133549d5b289bd5494a4264a73d
treebada4b70bf254cf95461a7221cf9d7c2c0eb3597
parenta4f63634760acfcc349a5582c77ca4a004c813f6
net: mvmdio: fix interrupt timeout handling

This version corrects the whitespace issue.

orion_mdio_wait_ready uses wait_event_timeout to wait for the
SMI interrupt to fire.  wait_event_timeout waits for between
"timeout - 1" and "timeout" jiffies.  In this case a 1ms timeout
when HZ is 1000 results in a wait of 0 to 1 jiffies, causing
premature timeouts.

This fix ensures a minimum timeout of 2 jiffies, ensuring
wait_event_timeout will always wait at least 1 jiffie.

Issue reported by Nicolas Schichan.

Tested-by: Nicolas Schichan <nschichan@freebox.fr>
Signed-off-by: Leigh Brown <leigh@solinno.co.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/marvell/mvmdio.c