]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
pwm: pxa: Use module_platform_driver
authorMike Dunn <mikedunn@newsguy.com>
Thu, 8 Aug 2013 17:00:37 +0000 (10:00 -0700)
committerThierry Reding <thierry.reding@gmail.com>
Tue, 3 Sep 2013 11:09:17 +0000 (13:09 +0200)
commit1e185c7aafbb56580feaa5bdbc9e4b1d8efaf710
tree802a9dd5436b907cb78355599674ac7e085d620a
parentac872bc9ed4452dccfbcebe7d273350103464998
pwm: pxa: Use module_platform_driver

Commit 76abbdde2d95a3807d0dc6bf9f84d03d0dbd4f3d

    pwm: Add sysfs interface

causes a kernel oops due to a null pointer dereference on PXA platforms.
This happens because the class added by the patch is registered in a
subsys_initcall (initcall4), but the pxa pwm driver is registered in
arch_initcall (initcall3). If the class is not registered before the
driver probe function runs, the oops occurs in device_add() when the
uninitialized pointers in struct class are dereferenced.  I don't see a
reason that the driver must be an arch_initcall, so this patch makes it
a regular module_platform_driver (initcall6), preventing the oops.

Signed-off-by: Mike Dunn <mikedunn@newsguy.com>
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Acked-by: Marek Vasut <marex@denx.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-pxa.c