]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
HID: microsoft: do not use compound literal - fix build
authorJiri Slaby <jslaby@suse.cz>
Mon, 12 Nov 2012 09:16:09 +0000 (10:16 +0100)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 10 Apr 2013 02:20:16 +0000 (03:20 +0100)
commit1e8b82e5787b57c83674e6ac87da4060dded3184
treede35e37cdb22f9dfe80ca9e7c9c2cac9e678a9bf
parentc5b444a3da735cc82ea736ddcf816cfedee7f941
HID: microsoft: do not use compound literal - fix build

commit 6b90466cfec2a2fe027187d675d8d14217c12d82 upstream.

In patch "HID: microsoft: fix invalid rdesc for 3k kbd" I fixed
support for MS 3k keyboards. However the added check using memcmp and
a compound statement breaks build on architectures where memcmp is a
macro with parameters.

hid-microsoft.c:51:18: error: macro "memcmp" passed 6 arguments, but takes just 3

On x86_64, memcmp is a function, so I did not see the error.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/hid/hid-microsoft.c