]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
xen: use stronger barrier after unlocking lock
authorYang Xiaowei <xiaowei.yang@intel.com>
Wed, 9 Sep 2009 19:44:52 +0000 (12:44 -0700)
committerJeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Wed, 9 Sep 2009 23:38:44 +0000 (16:38 -0700)
commit2496afbf1e50c70f80992656bcb730c8583ddac3
treefd701f588d8194cb1b296eca9c6288b6b8c342a1
parent4d576b57b50a92801e6493e76e5243d6cff193d2
xen: use stronger barrier after unlocking lock

We need to have a stronger barrier between releasing the lock and
checking for any waiting spinners.  A compiler barrier is not sufficient
because the CPU's ordering rules do not prevent the read xl->spinners
from happening before the unlock assignment, as they are different
memory locations.

We need to have an explicit barrier to enforce the write-read ordering
to different memory locations.

Because of it, I can't bring up > 4 HVM guests on one SMP machine.

[ Code and commit comments expanded -J ]

[ Impact: avoid deadlock when using Xen PV spinlocks ]

Signed-off-by: Yang Xiaowei <xiaowei.yang@intel.com>
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
arch/x86/xen/spinlock.c