]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
net: allow pskb_expand_head() to get maximum tailroom
authorEric Dumazet <eric.dumazet@gmail.com>
Tue, 10 Apr 2012 20:08:39 +0000 (20:08 +0000)
committerBen Hutchings <ben@decadent.org.uk>
Fri, 11 May 2012 12:14:22 +0000 (13:14 +0100)
commit34b0788a13e9c65440e3d736a91f75964356ad67
tree1bc7592bfca557e68dc4d7e81dfa7055da3e4aa6
parent65355aea86b2a70cbc7cbe14466702bc5a4e2217
net: allow pskb_expand_head() to get maximum tailroom

[ Upstream commit 87151b8689d890dfb495081f7be9b9e257f7a2df ]

Marc Merlin reported many order-1 allocations failures in TX path on its
wireless setup, that dont make any sense with MTU=1500 network, and non
SG capable hardware.

Turns out part of the problem comes from pskb_expand_head() not using
ksize() to get exact head size given by kmalloc(). Doing the same thing
than __alloc_skb() allows more tailroom in skb and can prevent future
reallocations.

As a bonus, struct skb_shared_info becomes cache line aligned.

Reported-by: Marc MERLIN <marc@merlins.org>
Tested-by: Marc MERLIN <marc@merlins.org>
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
net/core/skbuff.c