]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
[media] cx23885: Replace memcpy with struct assignment
authorEzequiel Garcia <elezegarcia@gmail.com>
Tue, 23 Oct 2012 18:57:20 +0000 (15:57 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Thu, 27 Dec 2012 21:02:09 +0000 (19:02 -0200)
commit3618acab2ccefe292a3b1a1d7295f1368023b71a
tree475a3996de0134229de3b5d533d4c5078baf5200
parentb52377475ae9dca21bcb1ae8ec0936fbae8595b2
[media] cx23885: Replace memcpy with struct assignment

This kind of memcpy() is error-prone. Its replacement with a struct
assignment is prefered because it's type-safe and much easier to read.
Found by coccinelle. Hand patched and reviewed.
Tested by compilation only.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
identifier struct_name;
struct struct_name to;
struct struct_name from;
expression E;
@@
-memcpy(&(to), &(from), E);
+to = from;
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com>
Reviewed-by: Andy Walls <awalls@md.metrocast.net>
Signed-off-by: Andy Walls <awalls@md.metrocast.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/pci/cx23885/cx23885-video.c
drivers/media/pci/cx23885/cx23888-ir.c