]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
kernel/resource.c: fix stack overflow in __reserve_region_with_split()
authorT Makphaibulchoke <tmac@hp.com>
Thu, 13 Sep 2012 01:01:37 +0000 (11:01 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Thu, 13 Sep 2012 07:28:22 +0000 (17:28 +1000)
commit38da97ca0373efc8d72e0fe56a05666fa0c1c8c2
treee8c4e1efb47d0607f5a952d8c34f5fbb7e93b6c8
parent1110941905076d715c56f988337245ae57b00bb0
kernel/resource.c: fix stack overflow in __reserve_region_with_split()

Using a recurvise call add a non-conflicting region in
__reserve_region_with_split() could result in a stack overflow in the case
that the recursive calls are too deep.  Convert the recursive calls to an
iterative loop to avoid the problem.

Tested on a machine containing 135 regions.  The kernel no longer panicked
with stack overflow.

Also tested with code arbitrarily adding regions with no conflict,
embedding two consecutive conflicts and embedding two non-consecutive
conflicts.

Signed-off-by: T Makphaibulchoke <tmac@hp.com>
Reviewed-by: Ram Pai <linuxram@us.ibm.com>
Cc: Paul Gortmaker <paul.gortmaker@gmail.com>
Cc: Wei Yang <weiyang@linux.vnet.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
kernel/resource.c