]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
UBI: block: fix dereference on uninitialized dev
authorColin Ian King <colin.king@canonical.com>
Wed, 20 Aug 2014 09:19:38 +0000 (10:19 +0100)
committerArtem Bityutskiy <artem.bityutskiy@linux.intel.com>
Tue, 16 Sep 2014 16:02:04 +0000 (19:02 +0300)
commit3df770725339c41d1cd9be4da4ca0d968119d8ad
tree75ea40d96de8dce7450bbd306c22f6350c1e5edf
parent1bf1890e86869032099b539bc83b098be12fc5a7
UBI: block: fix dereference on uninitialized dev

commit 4df38926f337 ("UBI: block: Avoid disk size integer overflow")
introduced a dereference on dev (which is not initialized at that
point) when printing a warning message.  Re-order disk_capacity check
after the dev is found.

Found by cppcheck:
 [drivers/mtd/ubi/block.c:509]: (error) Uninitialized variable: dev

Artem: tweak the error message a bit

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
drivers/mtd/ubi/block.c