]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
serial8250: sanity check nr_uarts on all paths.
authorEric W. Biederman <ebiederm@xmission.com>
Sat, 12 Jul 2008 21:40:32 +0000 (21:40 +0000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 24 Jul 2008 16:14:09 +0000 (09:14 -0700)
commit57dc6158b397beba881fa405cbafcfb99b57dd5e
tree3f2b3df785c2f6b734d3eb6750b4ae4449133b07
parent94db799b920539daf593ab48365ee0d71ce3dbf7
serial8250: sanity check nr_uarts on all paths.

commit 05d81d2222beec7b63ac8c1c8cdb5bb4f82c2bad upstream

I had 8250.nr_uarts=16 in the boot line of a test kernel and I had a weird
mysterious crash in sysfs.  After taking an in-depth look I realized that
CONFIG_SERIAL_8250_NR_UARTS was set to 4 and I was walking off the end of
the serial8250_ports array.

Ouch!!!

Don't let this happen to someone else.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Acked-by: Alan Cox <alan@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/serial/8250.c