]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
vfs: Revert spurious fix to spinning prevention in prune_icache_sb
authorSuleiman Souhlal <suleiman@google.com>
Sat, 13 Apr 2013 23:03:06 +0000 (16:03 -0700)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 25 Apr 2013 19:25:39 +0000 (20:25 +0100)
commit5ef143d96cf46e05a1bb7af5b2d4c3f6533c8b62
tree873c5c64e8970d1c28d122d7c5eb99966434c718
parentc6680a1301578e09b51a5ad68f9c00cb23d28fa3
vfs: Revert spurious fix to spinning prevention in prune_icache_sb

commit 5b55d708335a9e3e4f61f2dadf7511502205ccd1 upstream.

Revert commit 62a3ddef6181 ("vfs: fix spinning prevention in prune_icache_sb").

This commit doesn't look right: since we are looking at the tail of the
list (sb->s_inode_lru.prev) if we want to skip an inode, we should put
it back at the head of the list instead of the tail, otherwise we will
keep spinning on it.

Discovered when investigating why prune_icache_sb came top in perf
reports of a swapping load.

Signed-off-by: Suleiman Souhlal <suleiman@google.com>
Signed-off-by: Hugh Dickins <hughd@google.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
fs/inode.c