]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
The current implementation of dmi_name_in_vendors() is an invitation to
authorJean Delvare <khali@linux-fr.org>
Wed, 24 Aug 2011 23:46:29 +0000 (09:46 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Tue, 27 Sep 2011 07:13:49 +0000 (17:13 +1000)
commit752f941047d86180a953ea6ed3aedffd434ed486
treed0d23cb5c4d1462f37121422257122818b389284
parent07aea3b3a8fcc5395fb7ad0067d14a7389a113e6
The current implementation of dmi_name_in_vendors() is an invitation to
lazy coding and false positives [1].  Searching for a string in 8 know
what you're looking for, so you should know where to look.  strstr isn't
fast, especially when it fails, so we should avoid calling it when it just
can't succeed.

Looking at the current users of the function, it seems clear to me that
they are looking for a system or board vendor name, so let's limit
dmi_name_in_vendors to these two DMI fields.  This much better matches the
function name, BTW.

[1] We currently have code looking for short names in DMI data, such
as "IBM", "ASUS" or "Acer". I let you guess what will happen the day
other vendors ship products named, for example, "SCHREIBMEISTER",
"PEGASUS" or "Acerola".

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
drivers/firmware/dmi_scan.c