]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
staging: comedi: Fix reversed test in comedi_device_attach()
authorIan Abbott <abbotti@mev.co.uk>
Tue, 14 Aug 2012 10:29:17 +0000 (11:29 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Aug 2012 23:52:17 +0000 (16:52 -0700)
commit80eb7a506fdcea08f86c9dfc7c638303bf02a3c8
tree5554495632f96f05252bc9c3151b7cdb80c12f49
parenta26f4dd0ebd18f061366ca0231fdb74210e16140
staging: comedi: Fix reversed test in comedi_device_attach()

Commit 3902a370281d2f2b130f141e8cf94eab40125769 (staging: comedi:
refactor comedi_device_attach() a bit) by yours truly introduced an
inverted logic bug in comedi_device_attach() for the case where the
driver expects the device to be configured by driver name rather than
board name.  The result of a strcmp() is being tested incorrectly.  Fix
it.

Thanks to Stephen N Chivers for discovering the bug and suggesting the
fix.

Cc: <stable@vger.kernel.org> # 3.5.x
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers.c