]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
The dqc_bitmap field of struct ocfs2_local_disk_chunk is 32-bit aligned,
authorAkinobu Mita <akinobu.mita@gmail.com>
Wed, 24 Aug 2011 23:46:27 +0000 (09:46 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Thu, 1 Sep 2011 03:28:41 +0000 (13:28 +1000)
commit818e0da0c00fae19a1baacf9ae7e4a72d1f9de04
treee35912dce23c75d5cb89d72776992943ee8941ea
parentd4c68baee8e4c02bb559aa316bd0479b1f39659c
The dqc_bitmap field of struct ocfs2_local_disk_chunk is 32-bit aligned,
but not 64-bit aligned.  The dqc_bitmap is accessed by ocfs2_set_bit(),
ocfs2_clear_bit(), ocfs2_test_bit(), or ocfs2_find_next_zero_bit().  These
are wrapper macros for ext2_*_bit() which need to take an unsigned long
aligned address (though some architectures are able to handle unaligned
address correctly)

So some 64bit architectures may not be able to access the dqc_bitmap
correctly.

This avoids such unaligned access by using another wrapper functions for
ext2_*_bit().  The code is taken from fs/ext4/mballoc.c which also need to
handle unaligned bitmap access.

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Acked-by: Joel Becker <jlbec@evilplan.org>
Cc: Mark Fasheh <mfasheh@suse.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
fs/ocfs2/ocfs2.h
fs/ocfs2/quota_local.c