]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
ALSA: snd-usb: mixer: ignore -EINVAL in snd_usb_mixer_controls()
authorDaniel Mack <zonque@gmail.com>
Tue, 19 Mar 2013 20:09:25 +0000 (21:09 +0100)
committerTakashi Iwai <tiwai@suse.de>
Wed, 20 Mar 2013 07:43:00 +0000 (08:43 +0100)
commit83ea5d18d74f032a760fecde78c0210f66f7f70c
treeb9c37c3c341692eba1bbe54402a081be9d45759e
parent4d7b86c98e445b075c2c4c3757eb6d3d6efbe72e
ALSA: snd-usb: mixer: ignore -EINVAL in snd_usb_mixer_controls()

Creation of individual mixer controls may fail, but that shouldn't cause
the entire mixer creation to fail. Even worse, if the mixer creation
fails, that will error out the entire device probing.

All the functions called by parse_audio_unit() should return -EINVAL if
they find descriptors that are unsupported or believed to be malformed,
so we can safely handle this error code as a non-fatal condition in
snd_usb_mixer_controls().

That fixes a long standing bug which is commonly worked around by
adding quirks which make the driver ignore entire interfaces. Some of
them might now be unnecessary.

Signed-off-by: Daniel Mack <zonque@gmail.com>
Reported-and-tested-by: Rodolfo Thomazelli <pe.soberbo@gmail.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/mixer.c