]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
staging: comedi: pcl724: tidy up subdev_8255_init() calls
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Mon, 10 Jun 2013 17:15:55 +0000 (10:15 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 12 Jun 2013 00:16:46 +0000 (17:16 -0700)
commit84f7db9d8f9ee9bcee16143aab93b68b43e7e5cc
treebffa55087f24a082738b5382584cda8dc81eb158
parent0a0c2cb96b51c88d5a7c28ea8b1614cf421b8ae1
staging: comedi: pcl724: tidy up subdev_8255_init() calls

subdev_8255_init() can fail, make sure to check for it and return
the errno.

The private function subdev_8255_cb() is identical to the default
io callback used by the 8255 driver. Remove it and pass NULL to
subdev_8255_init() so the default callback will be used.

The private function subdev_8255mapped_cb() is used for the memory
memory mapped io of the pet48dio board. Rename this function so
it has namespace associated with the driver.

Casting the iobase passed to subdev_8255_init() is not needed.
Use a local variable for the iobase and remove the casts.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/pcl724.c