]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
do_wp_page: fix regression with execute in place
authorCarsten Otte <cotte@de.ibm.com>
Wed, 4 Feb 2009 23:12:16 +0000 (15:12 -0800)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 12 Feb 2009 17:50:22 +0000 (09:50 -0800)
commit8c47f86fb53485e298ed154eb5c0ca0a89b85a24
tree7f8332f8c11999de0c0eddc982bfebbe03bd4354
parent3bb90b5b5c86949bc3be417eea1eb85f10263098
do_wp_page: fix regression with execute in place

commit ab92661d5d9514647346047f30f67a7f35ffea67 upstream.

Fix do_wp_page for VM_MIXEDMAP mappings.

In the case where pfn_valid returns 0 for a pfn at the beginning of
do_wp_page and the mapping is not shared writable, the code branches to
label `gotten:' with old_page == NULL.

In case the vma is locked (vma->vm_flags & VM_LOCKED), lock_page,
clear_page_mlock, and unlock_page try to access the old_page.

This patch checks whether old_page is valid before it is dereferenced.

The regression was introduced by "mlock: mlocked pages are unevictable"
(commit b291f000393f5a0b679012b39d79fbc85c018233).

Signed-off-by: Carsten Otte <cotte@de.ibm.com>
Cc: Nick Piggin <npiggin@suse.de>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
mm/memory.c