]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
Revert "drm/i915/crt: Do not rely upon the HPD presence pin"
authorLinus Torvalds <torvalds@linux-foundation.org>
Fri, 8 Jun 2012 21:53:06 +0000 (14:53 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 8 Jun 2012 21:53:06 +0000 (14:53 -0700)
commit8f53369b753f5f4c7684c2eb0b592152abb1dd00
tree40b39dd3489cede6101a04e5096dba55a599a25c
parent77249539cd987884f86df6fd5c43b3dae1841be1
Revert "drm/i915/crt: Do not rely upon the HPD presence pin"

This reverts commit 9e612a008fa7fe493a473454def56aa321479495.

It incorrectly finds VGA connectors where none are attached, apparently
not noticing that nothing replied to the EDID queries, and happily using
the default EDID modes that have nothing to do with actual hardware.

That in turn then causes X to fall down to the lowest common
denominator, which is usually the default 1024x768 mode that is in the
default EDID and pretty much anything supports).

I'd suggest that if not relying on the HDP pin, the code should at least
check whether it gets valid EDID data back, rather than just assume
there's something on the VGA connector.

Cc: Dave Airlie <airlied@linux.ie>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/gpu/drm/i915/intel_crt.c