]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
ALSA: hda - Fix empty DAC filling in patch_via.c
authorTakashi Iwai <tiwai@suse.de>
Wed, 7 Nov 2012 09:32:47 +0000 (10:32 +0100)
committerBen Hutchings <ben@decadent.org.uk>
Fri, 16 Nov 2012 16:47:10 +0000 (16:47 +0000)
commit93939c34d9fa85c8fa27346b6a9ef08bd77984ce
tree44c7efa6849fffc9035a10cfb42e649333824f3b
parent859f2c0d443558ff604c370cb238182ef2786410
ALSA: hda - Fix empty DAC filling in patch_via.c

commit 5b3761954dac2d1393beef8210eb8cee81d16b8d upstream.

In via_auto_fill_adc_nids(), the parser tries to fill dac_nids[] at
the point of the current line-out (i).  When no valid path is found
for this output, this results in dac = 0, thus it creates a hole in
dac_nids[].  This confuses is_empty_dac() and trims the detected DAC
in later reference.

This patch fixes the bug by appending DAC properly to dac_nids[] in
via_auto_fill_adc_nids().

Reported-by: Massimo Del Fedele <max@veneto.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
sound/pci/hda/patch_via.c