]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
[PATCH] roundup_pow_of_two() 64-bit fix
authorAndrew Morton <akpm@osdl.org>
Sat, 25 Mar 2006 11:08:01 +0000 (03:08 -0800)
committerLinus Torvalds <torvalds@g5.osdl.org>
Sat, 25 Mar 2006 16:22:58 +0000 (08:22 -0800)
commit962749af67b145c57917bfbff3c303ebd7d5988c
treece454f8a1cb0beb89c875a11d31426a4b44ca0ba
parent231bed205879236357171e50bd8965e70797ecdc
[PATCH] roundup_pow_of_two() 64-bit fix

fls() takes an integer, so roundup_pow_of_two() is busted for ulongs larger
than 2^32-1.

Fix this by implementing and using fls_long().

(Why does roundup_pow_of_two() return a long?)

(Why is roundup_pow_of_two() __attribute_const__ whereas long_log2() is
__attribute_pure__?)

(Why does long_log2() suck so much?  Because we were missing fls_long()?)

Cc: Roland Dreier <rdreier@cisco.com>
Cc: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
Cc: John Hawkes <hawkes@sgi.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
include/linux/bitops.h
include/linux/kernel.h