]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
drm/i915: use correct node for handling cache domain eviction
authorMatthew Auld <matthew.auld@intel.com>
Mon, 6 Mar 2017 23:54:01 +0000 (23:54 +0000)
committerJani Nikula <jani.nikula@intel.com>
Mon, 13 Mar 2017 15:30:09 +0000 (17:30 +0200)
commitaac66bf5f916f645bd57029490a72c3f91f2c274
treeca096e6bb7016f58da1f0ee22cbeeadbc4a72b0a
parent5a8cf90d743f2d05433c6109f6c1b9b904b0cdb7
drm/i915: use correct node for handling cache domain eviction

It looks like we were incorrectly comparing vma->node against itself
instead of the target node, when evicting for a node on systems where we
need guard pages between regions with different cache domains. As a
consequence we can end up trying to needlessly evict neighbouring nodes,
even if they have the same cache domain, and if they were pinned we
would fail the eviction.

Fixes: 625d988acc28 ("drm/i915: Extract reserving space in the GTT to a helper")
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: http://patchwork.freedesktop.org/patch/msgid/20170306235414.23407-3-matthew.auld@intel.com
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
(cherry picked from commit fe65cbdbc97929e4a522716ed279a36783656142)
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/i915_gem_evict.c