]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
target: remove ->put_session method
authorChristoph Hellwig <hch@lst.de>
Sun, 3 May 2015 06:54:42 +0000 (08:54 +0200)
committerNicholas Bellinger <nab@linux-iscsi.org>
Sun, 31 May 2015 05:42:40 +0000 (22:42 -0700)
commitafe92323f9df4a2c4a093cd3f2a3f82800498596
tree0ebe00790ea7727b63f02aea1ca00e5b596c310b
parent7ad34a93675e9c5a65711f83c518871317adc2ee
target: remove ->put_session method

The only instance of ->put_session is in qla2xxx, and was added by commit
aaf68b ("tcm_qla2xxx: Convert to TFO->put_session() usage") with the following
description:

    This patch converts tcm_qla2xxx code to use an internal kref_put() for
    se_session->sess_kref in order to ensure that qla_hw_data->hardware_lock
    can be held while calling qlt_unreg_sess() for the final put.

But these day we're already holding the hardware lock over qlt_unreg_sess in
the ->close_session callback, so we're fine without this method.

(Re-add missing tcm_qla2xxx_release_session + drop put_session usage - nab)

Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Himanshu Madhani <himanshu.madhani@qlogic.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/scsi/qla2xxx/tcm_qla2xxx.c
drivers/target/target_core_transport.c
drivers/xen/xen-scsiback.c
include/target/target_core_fabric.h