]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
md/raid1: fix_read_error should act on all non-faulty devices.
authorNeilBrown <neilb@suse.de>
Thu, 18 Sep 2014 01:09:04 +0000 (11:09 +1000)
committerNeilBrown <neilb@suse.de>
Mon, 22 Sep 2014 01:26:01 +0000 (11:26 +1000)
commitb8cb6b4c121e1bf1963c16ed69e7adcb1bc301cd
treed9d8fcff94a5cbcfdbaba73a2a47a3ffce6ffd6d
parent34e97f170149bfa14979581c4c748bc9b4b79d5b
md/raid1: fix_read_error should act on all non-faulty devices.

If a devices is being recovered it is not InSync and is not Faulty.

If a read error is experienced on that device, fix_read_error()
will be called, but it ignores non-InSync devices.  So it will
neither fix the error nor fail the device.

It is incorrect that fix_read_error() ignores non-InSync devices.
It should only ignore Faulty devices.  So fix it.

This became a bug when we allowed reading from a device that was being
recovered.  It is suitable for any subsequent -stable kernel.

Fixes: da8840a747c0dbf49506ec906757a6b87b9741e9
Cc: stable@vger.kernel.org (v3.5+)
Reported-by: Alexander Lyakas <alex.bolshoy@gmail.com>
Tested-by: Alexander Lyakas <alex.bolshoy@gmail.com>
Signed-off-by: NeilBrown <neilb@suse.de>
drivers/md/raid1.c