]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
dm9601: fix phy/eeprom write routine
authorPeter Korsgaard <jacmet@sunsite.dk>
Mon, 3 May 2010 10:01:26 +0000 (10:01 +0000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Wed, 12 May 2010 21:57:05 +0000 (14:57 -0700)
commitb8f8bdedc62360a2bc26b8788d9f7ecf13ed448d
treea9d12d324292ce4ad97f9522e66b304956561af0
parenta59bb6a18c9fc9ed48804d5d2868ce2d301925e5
dm9601: fix phy/eeprom write routine

commit e9162ab1610531d6ea6c1833daeb2613e44275e8 upstream.

Use correct bit positions in DM_SHARED_CTRL register for writes.

Michael Planes recently encountered a 'KY-RS9600 USB-LAN converter', which
came with a driver CD containing a Linux driver. This driver turns out to
be a copy of dm9601.c with symbols renamed and my copyright stripped.
That aside, it did contain 1 functional change in dm_write_shared_word(),
and after checking the datasheet the original value was indeed wrong
(read versus write bits).

On Michaels HW, this change bumps receive speed from ~30KB/s to ~900KB/s.
On other devices the difference is less spectacular, but still significant
(~30%).

Reported-by: Michael Planes <michael.planes@free.fr>
Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/net/usb/dm9601.c