]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
libata: fix NULL sdev dereference race in atapi_qc_complete()
authorTejun Heo <tj@kernel.org>
Mon, 1 Nov 2010 10:39:19 +0000 (11:39 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 9 Dec 2010 21:26:52 +0000 (13:26 -0800)
commitbdfddf11e44234d16e2f0a46c672da72044d034a
tree6d4159a4d5164e4e6fe20621a17162f68caa1bce
parentc4fb9d1fb7b82a6894f7c63194e68f4c7b819ad4
libata: fix NULL sdev dereference race in atapi_qc_complete()

commit 2a5f07b5ec098edc69e05fdd2f35d3fbb1235723 upstream.

SCSI commands may be issued between __scsi_add_device() and dev->sdev
assignment, so it's unsafe for ata_qc_complete() to dereference
dev->sdev->locked without checking whether it's NULL or not.  Fix it.

Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/ata/libata-scsi.c