]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
xfrm: Workaround incompatibility of ESN and async crypto
authorSteffen Klassert <steffen.klassert@secunet.com>
Tue, 4 Sep 2012 00:03:29 +0000 (00:03 +0000)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 10 Oct 2012 02:31:20 +0000 (03:31 +0100)
commitbf08fec505c1ab6a12679c214d7ccd20c8841382
treeba222f4f77839e6c4bf4b0b856a2f17785b02790
parentabf9fdb3f9e0b78df8145e0d742d0a19f251910b
xfrm: Workaround incompatibility of ESN and async crypto

[ Upstream commit 3b59df46a449ec9975146d71318c4777ad086744 ]

ESN for esp is defined in RFC 4303. This RFC assumes that the
sequence number counters are always up to date. However,
this is not true if an async crypto algorithm is employed.

If the sequence number counters are not up to date on sequence
number check, we may incorrectly update the upper 32 bit of
the sequence number. This leads to a DOS.

We workaround this by comparing the upper sequence number,
(used for authentication) with the upper sequence number
computed after the async processing. We drop the packet
if these numbers are different.

To do this, we introduce a recheck function that does this
check in the ESN case.

Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
include/net/xfrm.h
net/xfrm/xfrm_input.c
net/xfrm/xfrm_replay.c