]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
PCI: Assign resources before drivers claim devices (pci_scan_bus())
authorYijing Wang <wangyijing@huawei.com>
Mon, 9 Mar 2015 02:33:58 +0000 (10:33 +0800)
committerBjorn Helgaas <bhelgaas@google.com>
Thu, 12 Mar 2015 20:04:01 +0000 (15:04 -0500)
commitc90570d9511d42421c85709b46bffd366185d835
tree63febf1d38c816fa7c540a8238f7436a9a483813
parentc517d838eb7d07bbe9507871fab3931deccff539
PCI: Assign resources before drivers claim devices (pci_scan_bus())

Previously, pci_scan_bus() created a root PCI bus, enumerated the devices
on it, and called pci_bus_add_devices(), which made the devices available
for drivers to claim them.

Most callers assigned resources to devices after pci_scan_bus() returns,
which may be after drivers have claimed the devices.  This is incorrect;
the PCI core should not change device resources while a driver is managing
the device.

Remove pci_bus_add_devices() from pci_scan_bus() and do it after any
resource assignment in the callers.

[bhelgaas: changelog, check for failure in mcf_pci_init()]
Signed-off-by: Yijing Wang <wangyijing@huawei.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
CC: "David S. Miller" <davem@davemloft.net>
CC: Geert Uytterhoeven <geert@linux-m68k.org>
CC: Guan Xuetao <gxt@mprc.pku.edu.cn>
CC: Richard Henderson <rth@twiddle.net>
CC: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
CC: Matt Turner <mattst88@gmail.com>
arch/alpha/kernel/sys_nautilus.c
arch/m68k/coldfire/pci.c
arch/sparc/kernel/pcic.c
arch/unicore32/kernel/pci.c
drivers/pci/hotplug/ibmphp_core.c
drivers/pci/probe.c