]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
oProfile: oops when profile_pc() returns ~0LU
authorPhilippe Elie <phil.el@wanadoo.fr>
Thu, 15 Nov 2007 00:58:48 +0000 (16:58 -0800)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 26 Nov 2007 17:42:28 +0000 (09:42 -0800)
commitca6c1144759bdcf92839694a3f16880e2e43305a
treee7f6f4b9b04f5c1dc5957c8c4b8e113fd344d36b
parentf4c2ff65ba0168f9e5283890e22add4ed6cb9ba9
oProfile: oops when profile_pc() returns ~0LU

patch df9d177aa28d50e64bae6fbd6b263833079e3571 in mainline.

Instruction pointer returned by profile_pc() can be a random value.  This
break the assumption than we can safely set struct op_sample.eip field to a
magic value to signal to the per-cpu buffer reader side special event like
task switch ending up in a segfault in get_task_mm() when profile_pc()
return ~0UL.  Fixed by sanitizing the sampled eip and reject/log invalid
eip.

Problem reported by Sami Farin, patch tested by him.

Signed-off-by: Philippe Elie <phil.el@wanadoo.fr>
Tested-by: Sami Farin <safari-kernel@safari.iki.fi>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/oprofile/cpu_buffer.c
drivers/oprofile/cpu_buffer.h
drivers/oprofile/oprofile_stats.c